[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] dwv



Yes, this plugin depends on Orthanc 0.8.6 (the latest). So either liborthancclient-dev or the new orthanc-dev.

For _javascript_, it seems that I either need to include debian packaged ones (like jquery) or provide the sources. From what I get that was done in the orthanc-webviewer, by _javascript_ sources, it is meant non minified code? Is that correct?

On 17 March 2015 at 08:45, Andreas Tille <andreas@an3as.eu> wrote:
Hi Yves,

On Mon, Mar 16, 2015 at 11:17:41PM +0100, Yves wrote:
> I removed the gbp.conf file from the repository and am using a local one as
> you suggested.

OK.

> In order for the cowbuilder to work, I had to add a
> .pbuilderrc file with 'COMPONENTS="main universe multiverse restricted"' in
> it (as suggested here:
> http://askubuntu.com/questions/174378/cowbuilder-create-distribution-lucid-fails).

Hmmm, it seems you are using Ubuntu as main machine and also tried to
create an Ubuntu chroot.  Using Ubuntu for Debian development has proven
to be possible for several people in the past.  Usually they have setup
a Debian chroot to create the packages.  I would not say you should
change your current setup but we might experience differences between
our builds and thus I'm mentioning it to be careful if something might
fail for one of us and not for the other (since I'm using Debian
exclusively).

> I added a missing dependency to the control file and now have a successful
> git-buildpackage! The output is attached, can you confirm it is all good?

It looks good but there is no point in adding this to the mails.  I'll
checkout Git anyway and rebuild at my side.  And here it fails and this
is not related to the Debian-Ubuntu-difference.  It was since include
orthanc/OrthancCPlugin.h was missing and thus I did

$ git diff
diff --git a/debian/control b/debian/control
index ebf325e..2880471 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,8 @@ Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.
 Uploaders: Andreas Tille <tille@debian.org>
 Build-Depends: debhelper (>= 9),
                cmake (>= 2.8),
-               python
+               python,
+               liborthancclient-dev
 Standards-Version: 3.9.6
 Vcs-Browser: http://anonscm.debian.org/viewvc/debian-med/trunk/packages/dwv-orthanc-plugin/trunk/
 Vcs-Svn: svn://anonscm.debian.org/debian-med/trunk/packages/dwv-orthanc-plugin/trunk/

Since by default I have only unstable in the sources.list the install
used

Get: 1 http://http.debian.net/debian/ sid/main liborthancclient0.8 amd64 0.8.4+dfsg-2 [147 kB]
Get: 2 http://http.debian.net/debian/ sid/main liborthancclient-dev amd64 0.8.4+dfsg-2 [30.8 kB]

If the following problem is due to the requirement of a higher versioned
orthanc than we need a versioned Build-Depends (and I'd include
experimental in the sources.list and we need to target for experimental
distribution as long as 0.8.6 is in experimental).  With the current
status in Git I get:

...
cd /tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /tmp/buildd/dwv-orthanc-plugin-0.3.1 /tmp/buildd/dwv-orthanc-plugin-0.3.1 /tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu /tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu /tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu/CMakeFiles/DwvOrthancPlugin.dir/DependInfo.cmake --color=
Scanning dependencies of target DwvOrthancPlugin
make[3]: Leaving directory '/tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu'
make -f CMakeFiles/DwvOrthancPlugin.dir/build.make CMakeFiles/DwvOrthancPlugin.dir/build
make[3]: Entering directory '/tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_report /tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu/CMakeFiles 2
[ 66%] Building CXX object CMakeFiles/DwvOrthancPlugin.dir/Plugin.cpp.o
/usr/bin/c++   -DDwvOrthancPlugin_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2  -Wall -pedantic -Werror -fPIC -I/tmp/buildd/dwv-orthanc-plugin-0.3.1/obj-x86_64-linux-gnu/AUTOGENERATED    -o CMakeFiles/DwvOrthancPlugin.dir/Plugin.cpp.o -c /tmp/buildd/dwv-orthanc-plugin-0.3.1/Plugin.cpp
/tmp/buildd/dwv-orthanc-plugin-0.3.1/Plugin.cpp: In function 'int32_t OrthancPluginInitialize(OrthancPluginContext*)':
/tmp/buildd/dwv-orthanc-plugin-0.3.1/Plugin.cpp:108:53: error: 'OrthancPluginExtendOrthancExplorer' was not declared in this scope
   OrthancPluginExtendOrthancExplorer(context, answer);
                                                     ^
CMakeFiles/DwvOrthancPlugin.dir/build.make:65: recipe for target 'CMakeFiles/DwvOrthancPlugin.dir/Plugin.cpp.o' failed
make[3]: *** [CMakeFiles/DwvOrthancPlugin.dir/Plugin.cpp.o] Error 1
...

> So, to the next step... Should I switch back to not using pbuilder? I am
> not sure I got its purpose, is it to debug the build process?

Not at all pbuilder is the way to go and it is strongly recommended that
every package that is finally uploaded to Debian is created in a chroot
environment like pbuilder (there are alternatives like sbuild).  The
rationale behind this is that only the build in a chroot can guarantee
that the package is properly building on any Debian machine and does not
rely on any specifics of your own machine.  While you can safe some time
to use dimply debuild you need to make absolutely sure that the build
works in pbuilder.

> I also need
> to fix the lintian _javascript_ errors.

Yes.  Please ask for help if you have any trouble with this.

Kind regards

     Andreas.

--
http://fam-tille.de


--
To UNSUBSCRIBE, email to debian-med-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: [🔎] 20150317074512.GB547@an3as.eu" target="_blank">https://lists.debian.org/[🔎] 20150317074512.GB547@an3as.eu



Reply to: