[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: tvim



On Sun, 28 Jun 2009, Harry Rickards wrote:

> Mauro Lizaur wrote:
> > 
> > About lintian, using the --pedantic option I got this:
> > (Note that --pedantic isn't really required, but this got my attention)
> 
> Thanks, I've added that to my ~/.devscripts.
> 
> > % lintian -Ii --pedantic tvim_0.2-2_source.changes 
> > P: tvim source: direct-changes-in-diff-but-no-patch-system Makefile.am and 4 more
> > N: 
> > N:    The Debian diff.gz contains changes to files or creation of additional
> > N:    files outside the debian directory. Keeping the changes as separate
> > N:    patches under the control of a patch system allows for more fine grained
> > N:    control over them. The package will also more easily support possible
> > N:    future source package formats if all changes outside the debian
> > N:    directory are stored as patches.
> > N:    
> > N:    Severity: pedantic, Certainty: certain
> > N: 
> > 
> > % diff tvim-orig/tvim-0.2/Makefile.am tvim/tvim-0.2/Makefile.am 
> > 6c6
> > < tvimdocdir = ${prefix}/doc/tvim
> > ---
> >> tvimdocdir = ${prefix}/share/doc/tvim
> > 9d8
> > <       COPYING\
> > 12d10
> 
> Fixed now (I think). I've added patches for all the needed changes with
> dpatch, and removed all the stuff that wasn't needed (I think I
> accidently used ~/tvim/nm/tvim-0.2 as my working directory yesterday).
> Works fine in my chroot (is running Sid and has only got the needed
> packages for Debian to run plus the build dependencies and normal
> dependencies.) I've also removed UTF-8 from the FreeDesktop file via a
> patch, as it's been deprecated. Should I contact the upstream author and
> ask them to remove it from the upstream source, or just leave it?
> 
> 

Great, and contacting the upstream to remove the deprecated parts can be
a good idea, yes.

Regards,
Mauro

-- 
JID: lavaramano@jabber.org | http://lusers.com.ar/
2B82 A38D 1BA5 847A A74D 6C34 6AB7 9ED6 C8FD F9C1


Reply to: