Hi,
On Wed, Jul 22, 2015 at 11:57 AM, Andreas Tille <
andreas@an3as.eu> wrote:
>
> Hi Akshita,
>
> On Wed, Jul 22, 2015 at 03:17:50AM +0530, Akshita Jha wrote:
> >
> > I have committed and pushed my changes to the repository.
> > With this commit:
> > i) The Unicode Error in earlier UDD dumps is hopefully
>
> Hmmm, the hope did not fulfilled - at least on my side:
>
> $ tasks_udd.py debian-med
> Traceback (most recent call last):
> File "./tasks_udd.py", line 183, in <module>
> print >> f, template.generate(**data).render('xhtml')
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 1275: ordinal not in range(128)
>
Can you please confirm if you get this error on executing "./tasks.py debian-med" also ?
> It might be better if you do more granular commits for each
> separate problem.
>
I'll keep this in mind.
>
> I have some comments: You have some commented print statements.
> I think it would be more convinient if you simply would use
> logger.debug
> for this. I have the logger instance for this very purpose.
>
I have pushed this change to the repo,
> I would also be in favour of using a different output dir for the new
> code, say
>
> /srv/
blends.debian.org/www/med/tasks_udd>
> for Debian Med. The rationale is that we need to compare the output of
> the old and the new script.
This has also been committed pushed to the repo.
> I would even think it would be a good idea
> to write some kind of a test suite that does some automatic comparison
> between old and new output.
Yes. It is a good idea. I'll start working on this.
I had thought about this earlier but I wanted to first complete rewriting tasks.py to use UDD. Since, this has almost been done, we can start exporting the code to Python 3.