On Mon, 15 Dec 2008 10:53:36 +0100, Jonas Smedegaard wrote:
Hi Jonas, hi Paul,
thanks for your comments!
> On Mon, Dec 15, 2008 at 07:16:33PM +1100, Paul Fenwick wrote:
> >Jonas Smedegaard wrote:
> >> I believe that instead of removing that build-dependency you should
> >> change it to "Build-Conflicts:".
Thanks for adding this, I indeed forgot about the problems of the
combination of setting the flag and having BSD::Resource installed.
Still, I don't really like the idea of breaking builds with
BSD::Resource installed.
> >If the test *is* causing false positives, I'd prefer to just disable
> >the test than put in a build-conflicts. As an author test, it doesn't
> >come with any guarantees it will make work outside my development
> >machine.
> Yes, removing that flag is another option.
Ack.
What I'd like to see is the possibility to disable _this_ test and
enable the maintainer tests (pod, pod-coverage) nevertheless.
That should be possible by either having a different environment
variable or by setting explictly the tests we want to run.
> The package needs to _either_
> remove the flag or set the build-conflicts. My point is that it is wrong
> to simply remove the build-dependency, as that change alone will not
> ensure a sane build-environment: even if build-daemons usually provide a
> build environment containing a minimal set of package needed, this
> cannot be relied on.
Agreed.
> The reason that I favor enabling the option (+ properly
> build-conflicting) over disabling it is that it does provides a feature:
> The feature of doing extreme tests that you as upstream consider
> relevant only for you to do, but that might make sense for Debian to do
> as well - imagine to possibility of us patching the source for some
> reason, and thereby perhaps by accident lowering the quality of e.g.
> embedded documentation quality or indentation style or similar stuff
> checked by the extreme/exotic checking feature.
Ack, but then the test would have to work in the first place for me
:)
(I need to look into it further.)
> >> But as I posted a little earlier I suggest instead to keep the
> >> build-dependency and instead add the following in debian/rules to not
> >> enable the problematic option on normal builds:
> >> ifneq (,$(DEB_MAINTAINER_MODE))
> >> TEST_AUTHOR=1
> >> endif
> >I think this sounds like a fantastic idea.
Thanks Jonas for this idea.
I keep it in mind but IMO this doesn't scale for a group like ours
with >1000 packages where people use to touch dozens of them --
remembering (or reading) which specific options which packages need
for test builds seems a bit tedious in my view.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`- NP: Peter Jones: Sunshine Up Ahead
Attachment:
signature.asc
Description: Digital signature