Re: Author tests and IPC::System::Simple
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Sat, Dec 13, 2008 at 02:11:03AM +0100, gregor herrmann wrote:
>On Sat, 13 Dec 2008 11:19:48 +1100, Paul Fenwick wrote:
>> As such, if any of the author tests fail, it indicates there *may* be
>> a bug, as opposed to if any of the main tests which, which indicate
>> that there is definitely a bug.
>
>I completely agree, and that's why I just removed
>libbsd-resource-perl from Build-Depends-Indep to get the package out
>and mentioned the issue.
>
>But since any user might have installed libbsd-resource-perl (as
>opposed to a clean build environment) they might stumble across this
>issue, so just ignoring it is probably not appropriate.
I believe that instead of removing that build-dependency you should
change it to "Build-Conflicts:".
But as I posted a little earlier I suggest instead to keep the
build-dependency and instead add the following in debian/rules to not
enable the problematic option on normal builds:
ifneq (,$(DEB_MAINTAINER_MODE))
TEST_AUTHOR=1
endif
You can then enable the tests by either prepending DEB_MAINTAINER_MODE=1
to a plain debuild command, or add it to your cowbuild configuration
file to always enable it on your on build environment.
>> For an actual Debian
>> maintainer who is building packages on a known environment, it may be
>> reasonable to have them enabled, since they'll be able to properly triage
>> any failures reported by them. Even so, I'd be inclined to leave them off
>> by default.
>
>Debian packages are/have to be built in a clean environment, i.e. a
>base system plus the packages in Build-Depends{,-Indep}.
Hmm - above could be misunderstood: Debian packages are build in
environments with _at_ _least_ the core packages + declared
build-dependencies.
Package build for official release should be done on systems only
containing official packages from same release as targeted, but there is
no rule that superfluous packages should not exist in the build
environment.
...it just so happens that automated build environments tend to provide
the minimal required, in order to reveal missing dependencies.
Kind regards,
- Jonas
- --
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAklDKdsACgkQn7DbMsAkQLg+PgCdHpfPFMAmGqRmMYwLRjddvZqQ
3m4An33vM2r/oWqWuIgT1aQoOizEVG4M
=7TMN
-----END PGP SIGNATURE-----
Reply to: