[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gip (updated package, adopting, 2nd try)

Hi Ignace,

On Tue, Oct 06, 2009 at 12:09:43PM +0200, Ignace Mouzannar wrote:
> I have added a debian/gip.dirs file mentioning the usr/ directory. I
> find this much cleaner this way. Thank you for the suggestion.

Thought so. :)

> > Good. Two last comments:
> > a) You don't mention yourself in debian/copyright. You don't have to,
> >   but since you changes quite a lot you might want to add yourself for
> >   the files in debian/. Your choice.
> As the previous maintainer did a big part of the work, I prefer just
> having my name/email in the patches I have added, for further
> support/maintenance purposes.

Fine with me.

> > b) You should use dch (and the other fancy tools from devscripts) for
> >   changelog editing. dch automatically updates the timestamp and is
> >   eager to keep the format straight. I just noticed by the timestamp
> >   being September, 18th. :)
> I have updated the timestamp of debian/changelog using `dch -r`,
> mentioning the new debian/gip.dirs file.

Great. Uploaded.

It was nice working with you; feel free to contact me for updates.


Attachment: signature.asc
Description: Digital signature

Reply to: