[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] Packaging mindthemap (Was: Request to contribute to DebianMed and be part of MoM)



Hello,

Many thanks for your email and apologies for the confusion. My working directory at the time didn't look right so I have rectified it as a local issue on my side. 

I have ran some tests and have managed to build a binary and tests which work great. Now, it's a matter of packaging it into .deb. There's only a question I need to ask. gatb-core is, of course, a git submodule which will not be handled by uscan. This means that CMake will not work as it requires this as a dependency. What would be the best way of incorporating gatb-core into the root directory. Of course, I won't be able to just simply add a thirdparty folder for CMake to use because dpkg-source will complain of unrepresentable changes to source or binary file contents changed. Is this where I now have to rely on the pre-built gatb-core package that already exists within sid and testing as a build dependency by editing the rules and control file instead of going down this route? This only seems to be the last obstacle as for an experiment, I have managed to build some other packages but because by default thirdparty doesn't truly exist within upstream, I am unsure as to how I could add it within sources. I was thinking of quilt patching but I don't think that's the way to do it.

Just a small guidance and fix of direction would be greatly appreciated.

Many thanks,

Shayan Doust


July 2, 2019 10:26 PM, "Andreas Tille" <andreas@an3as.eu> wrote:

> Hi,
> 
> On Tue, Jul 02, 2019 at 06:56:14PM +0000, hello@shayandoust.me wrote:
> 
>> Hello,
>> 
>> Well, I've realised I've hit a slight issue. I am slightly confused here. When running the
>> personalise_template tool and using the uscan command, it seems like not all files have been
>> included from the github repository? The root directory of mindthegap on salsa is seemingly missing
>> container, doc, pipeline, INSTALL and thirdparty.
> 
> I cloned your repository and everything is fine. Since you used the
> --pristine-tar option in the `gbp import-orig` command a branch
> pristine-tar was created that enables byte identical recreation of the
> original tarball. This works for me - so the repository is fine.
> The Git repository is missing the dir thirdparty since Git ignores
> totally empty dirs (which is the case since gatb-core is an external
> module). I see the file INSTALL (no idea what you mean by the other
> files).
> 
>> Just confused as to why this could be.
> 
> As I said: I think everything is fine.
> 
> Regarding debian/changelog you need to leave the Debian revision -1
> like this:
> 
> diff --git a/debian/changelog b/debian/changelog
> index f183add..c31fbac 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,4 +1,4 @@
> -mindthegap (2.2.0) UNRELEASED; urgency=medium
> +mindthegap (2.2.0-1) UNRELEASED; urgency=medium
> 
> * Initial release (Closes: #<bug>)
> 
> Please now checkout how to setup git-buildpackage and pbuilder
> (for instance as described in Debian Med team policy which is
> linked from the MoM page) and try to build that state (or ask
> here if you face any questions).
> 
> Kind regards
> 
> Andreas.
> 
>> July 2, 2019 3:45 PM, "Andreas Tille" <andreas@an3as.eu> wrote:
>> 
>> Hello,
>> 
>> On Tue, Jul 02, 2019 at 01:52:41PM +0000, hello@shayandoust.me wrote:
>> 
>> Many thanks for the heads up.
>> 
>> I have followed the instructions you have updated on the MoM wiki. Everything seems to be
>> successful and I have a working debian directory.
>> 
>> Good!
>> 
>> I am now trying to use inject-into-salsa-git tool to push it onto the repository. The first time I
>> ran it, it failed. I presume the error was due to my missing SSH key (which I forgot to add to my
>> salsa git account). Now, I am retrying the tool. It says that "Project mindthemap does not exist on
>> Salsa - just create the project" even though the repository was created from the last attempt. The
>> preceding error message after that is the JSON output:
>> 
>> + RESPONSE={"message":{"name":["has already been taken"],"path":["has already been
>> taken"],"limit_reached":[]}}
>> + echo {"message":{"name":["has already been taken"],"path":["has already been
>> taken"],"limit_reached":[]}}
>> + jq --exit-status .id
>> 
>> Hmmm, that's strange. I wonder why the last attempt had created the
>> project when you had no Salsa token.
>> 
>> Any assistance would be much appreciated. I was thinking of using manual command entries to push
>> it, but I wasn't sure as to if that would meet the exact expected standard if it causes some
>> deviation. In addition, should I, from now on, create new emails instead of prolonging this chain
>> of emails with this subject?
>> 
>> For sure manual injection would be possible. But the script is not only
>> pushing all stuff it also sets some sensible hooks. Doing this all
>> manually is a nuisance. Thus I did what I always do if I'm running into
>> an error myself: Just removed the empty Git repository mindthemap from
>> Salsa. Now you can try again.
>> 
>> Feel free to take any subject you might consider sensible as long it
>> is tagged [MoM] - I did so now for my response.
>> 
>> Hope this helps
>> 
>> Andreas.
>> 
>> --
>> http://fam-tille.de
> 
> --
> http://fam-tille.de


Reply to: