Re: RFS: pyresample and pykdtree (was PtTroll)
Hi Andreas,
Il 25/06/2014 13:41, Andreas Tille ha scritto:
> Hi Antonio,
>
> thanks for your work on this.
>
> On Tue, Jun 24, 2014 at 08:45:50PM +0200, Antonio Valentino wrote:
>>> Hmmm, there should be no need to fiddle around with some pbuilder
>>> settings since if I would be forced to do this the autobuilders for
>>> other architectures will fail later. Can you confirm that you are
>>> able to build the package in a pbuilder environment?
>>>
>>> Kind regards
>>>
>>> Andreas.
>>>
>>
>> yes, it works out of the box using
>>
>> $ git-pbuilder create
>>
>> and
>>
>> $ git-buildpackage -us -uc --git-pbuilder
>
> I can confirm that it works on an other box of mine - so I was probably
> affected by a misconfiguration of one of my pbuilder environments.
OK
>
>> I created a new python-pyresample-test as requested and now pyresample
>> can be tested with autopkgtest.
>
> I checked this but this test will probably do nothing since
>
> pyversions -r 2
>
> does nothing but throw an error and the correct call
>
> pyversions -r 2.7
>
> has a result which you redirect to /dev/null which leeds to a loop over
> nothing. If you try
No, the executed command should be "pyversions -r" (without arguments)
that should list all the python versions specified in the control file
or (like in this case) fall back to "pyversions -s" that lists all
supported python2 versions.
[CUT]
>
> the test will result on my machine in four errors of type:
>
> Traceback (most recent call last):
> File "/usr/share/python-pyresample-test/test_plot.py", line 37, in test_area_def2basemap
> bmap = pr.plot.area_def2basemap(area_def)
> File "/usr/lib/python2.7/dist-packages/pyresample/plot.py", line 79, in area_def2basemap
> from mpl_toolkits.basemap import Basemap
> ImportError: No module named basemap
>
> which is caused by the lack of the dependency
> python-mpltoolkits.basemap. The most straightforward way to fix this is:
>
> $ git diff control
> diff --git a/debian/tests/control b/debian/tests/control
> index c123cb3..826a8c3 100644
> --- a/debian/tests/control
> +++ b/debian/tests/control
> @@ -1,2 +1,2 @@
> Tests: python2
> -Depends: python-pyresample, python-pyresample-test, python-all
> +Depends: @builddeps@, python-pyresample, python-pyresample-test, python-all
>
>
> Since this patch is quite clear I just commited it.
thank you for the fix
> I'll leave you
> the task to fix the debian/tests/python2 script since I might have
> overlooked something you might have had in mind.
>
> Kind regards
>
> Andreas.
IMO the debian/test/python2 script should be OK not that the dependency
issue has been fixed (see above).
I tested it locally using
$ adt-run -B --built-tree . --- adt-virt-null
Please let me know if you still have problems with it.
cheers
--
Antonio Valentino
Reply to: