[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: pyresample and pykdtree (was PtTroll)



Hi Antonio,

thanks for your work on this.

On Tue, Jun 24, 2014 at 08:45:50PM +0200, Antonio Valentino wrote:
> > Hmmm, there should be no need to fiddle around with some pbuilder
> > settings since if I would be forced to do this the autobuilders for
> > other architectures will fail later.  Can you confirm that you are
> > able to build the package in a pbuilder environment?
> > 
> > Kind regards
> > 
> >          Andreas.
> > 
> 
> yes, it works out of the box using
> 
> $ git-pbuilder create
> 
> and
> 
> $ git-buildpackage -us -uc --git-pbuilder

I can confirm that it works on an other box of mine - so I was probably
affected by a misconfiguration of one of my pbuilder environments.
 
> I created a new python-pyresample-test as requested and now pyresample
> can be tested with autopkgtest.

I checked this but this test will probably do nothing since 

   pyversions -r 2

does nothing but throw an error and the correct call

   pyversions -r 2.7

has a result which you redirect to /dev/null which leeds to a loop over
nothing.  If you try

$ git diff
diff --git a/debian/tests/python2 b/debian/tests/python2
index 5e409fe..a237ec7 100755
--- a/debian/tests/python2
+++ b/debian/tests/python2
@@ -1,7 +1,7 @@
 #!/bin/sh
 set -efu
 
-PYS=${PYS:-"$(pyversions -r 2>/dev/null)"}
+PYS=${PYS:-"$(pyversions -r 2.7)"}
 TESTPKG=${TESTPKG:-pyresample}
 
 cd "$ADTTMP"

the test will result on my machine in four errors of type:

Traceback (most recent call last):
  File "/usr/share/python-pyresample-test/test_plot.py", line 37, in test_area_def2basemap
    bmap = pr.plot.area_def2basemap(area_def)
  File "/usr/lib/python2.7/dist-packages/pyresample/plot.py", line 79, in area_def2basemap
    from mpl_toolkits.basemap import Basemap
ImportError: No module named basemap
 
which is caused by the lack of the dependency
python-mpltoolkits.basemap.  The most straightforward way to fix this is:

$ git diff control 
diff --git a/debian/tests/control b/debian/tests/control
index c123cb3..826a8c3 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,2 +1,2 @@
 Tests: python2
-Depends: python-pyresample, python-pyresample-test, python-all
+Depends: @builddeps@, python-pyresample, python-pyresample-test, python-all


Since this patch is quite clear I just commited it.  I'll leave you
the task to fix the debian/tests/python2 script since I might have
overlooked something you might have had in mind.

Kind regards

         Andreas.


-- 
http://fam-tille.de


Reply to: