[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [boot-floppies] `mke2fs' and new Linux 2.2 ext2 features ?



Sorry, I was confused.

In article <y5ak8ksp1w6.fsf@kgh12351.nifty.ne.jp>,
  at 30 Jan 2000 14:24:57 +0900,
    on Re: [boot-floppies] `mke2fs' and new Linux 2.2 ext2 features ?,
 Taketoshi Sano <kgh12351@nifty.ne.jp> writes:

> >   /* Oflag:  1 == 2.0 compat; 0 == 2.2 only */

I think this comment is inverted. 

In according to the line

>   sprintf(prtbuf, "mkfs.ext2 %s %s %s",( Oflag ? "" : "-O none"),
>           ( cflag ? "-c" : ""), p->name);

then Oflag=1 means 2.2 only, and Oflag=0 means 2.0 compat (mke2fs -O none)

So,

> >   Oflag = 0;

this default does retain 2.0 compat. But,

> >   if ( bootargs.isverbose ) {
> >     sprintf(prtbuf, _("This 2.2 version of the Linux kernel has new \"ext2\" filesystem features not present in earlier kernel versions. Using these features, however, means that you can no longer run earlier kernels, such as Linux 2.0. Do you want to retain Linux kernel 2.0 compatability?"),
> > 	  p->name);
> >     Oflag = yesNoBox(prtbuf, _("Pre-2.2 Linux Kernel Compatibility?"));
> >   }

This Oflag = yesNoBox() may be wrong, because yesNoBox() returns -1 for "Yes",
or 0 for "No". Should this be changed to "Oflat = ! yesNoBox()" ?

If I was still confused now, please ignore me. Maybe it's the time to sleep...

-- 
  Taketoshi Sano: <sano@debian.org>,<sano@debian.or.jp>,<kgh12351@nifty.ne.jp>


Reply to: