Re: [GsoC] your latest commit of tasks_udd.py
Hi Akshita,
On Thu, Jul 23, 2015 at 06:45:22PM +0530, Akshita Jha wrote:
> >
> > OK, seems just a replacement of has_key, right? Looks sensible.
>
> Yes. It was just a replacement of 'has_key' in all the template files.
OK, sounds pretty harmless.
> > Ahh, you were able to fix this in the code? I understood[0] as if we
> > would need a fixed python3-genshi package. Could you please be a bit
> > more verbose about this? The thing is that we might need to backport
> > python2-genshi to Debian 8 to enable running our scripts on the final
> > destination. That's generally no problem but we need to remember this.
> >
>
> We indeed need to fix python3-genshi package. There was an error in the
> line : print(template.generate(**data).render('xhtml'), file=f) in
> tasks_udd.py with Traceback to
> .
> .
> .
> raise Exception('Unhandled node type %r' % type(node))
> Exception: Unhandled node type <class '_ast.NameConstant'>
>
> Similar errors shown in [0].
>
> To rectify this error:
> - I applied the patch [1] to
> /usr/local/lib/python3.4/dist-packages/genshi/compat.py.
Thi patch applies to the genshi version in testing (which I'm using).
> - Applied patch [2] and [3] to the
> /usr/local/lib/python3.4/dist-packages/genshi/template/astutil.py and
> /usr/local/lib/python3.4/dist-packages/genshi/template/eval.py files.
These patches do not apply. What genshi version are you using? I'm
using:
$ apt-cache policy python3-genshi
python3-genshi:
Installed: 0.7-3
Candidate: 0.7-3
Version table:
*** 0.7-3 0
501 http://httpredir.debian.org/debian/ testing/main amd64 Packages
50 http://httpredir.debian.org/debian/ unstable/main amd64 Packages
100 /var/lib/dpkg/status
and I did not faced any error. So may be you are using stable with an
older version of Genshi and we just need to create a backport? If this
is the case I'd immediately upload a backport.
Kind regards
Andreas.
> > > [0] http://genshi.edgewall.org/ticket/582
> [1] http://genshi.edgewall.org/changeset/1248
> [2] http://genshi.edgewall.org/changeset/1249
> [3] http://genshi.edgewall.org/changeset/1250
--
http://fam-tille.de
Reply to: