Am Freitag, den 13.11.2020, 15:39 +0100 schrieb Klaumi Klingsporn:
> Am / On Thu, 12 Nov 2020 01:40:48 +0100
> schrieb / wrote Daniel Leidert <dleidert@debian.org>:
>
> > You can _definitely_ trim debian/changelog. A few hints:
>
> Thanks for your hints. I tried to clean it up accordingly.
>
> > - I wouldn't use sublists. Personally I prefer a
> > different approach (
> > https://salsa.debian.org/ruby-team/jekyll/-/blob/master/debian/changelog)
>
> I kept the sub-lists. As I understood maintaining the ruby
> packages wants to be a team effort and therefore it might
> be useful that you easily can see who made a special
> change. But feel free to change it to whatever you want ;-)
I'll trim it down further. To avoid a misunderstanding: I meant I don't like
this:
* debian/very_long_file_name: - long comment
- long comment
Lines must not be longer than 79 characters. That's why I suggest to use
* debian/very_long_file_name:
- long comment with
linebreak
- next comment
or another format. I gave you some hints. You'll get more here (German):
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.de.html#best-practices-for-debian-changelog
There are some lintian issues to address (enable the pedantic and extra
output). You can ignore the gpg and debhelper related tags. There is no signed
tarball and debehlper 12 is fine. But these need to be addressed:
P: silent-on-rules-requiring-root
P: ruby-cmdparse source: trailing-whitespace debian/control (line 25)
P: ruby-cmdparse source: trailing-whitespace debian/control (line 26)
P: ruby-cmdparse source: trailing-whitespace debian/control (line 27)
X: ruby-cmdparse source: upstream-metadata-file-is-missing
The last file can be created by running dh-make-ruby in the tree. Then adjust
debian/upstream/metadata accordingly and remove all debian/ruby-tests.* files
created (because there are no tests).
Please also add this line to debian/rules:
export DH_RUBY = --gem-install
Use the gem installation layout which is better for most gems.
In d/control in the Depends field remove the interpreters and use
${ruby:Depends}. And I think consensus is to start the short description with a
lower case character. I think you can remove ruby-minitest from Build-Depends.
It was used by the test which does not exist anymore. The Maintainer is:
Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
In d/copyright you probably want to add yourself for debian/*.
Regards, Daniel
--
Regards,
Daniel Leidert <dleidert@debian.org> | https://www.wgdd.de/
GPG-Key RSA4096 / BEED4DED5544A4C03E283DC74BCD0567C296D05D
GPG-Key ED25519 / BD3C132D8B3805D1808123AB7ACE00941E338C78
If you like my work consider sponsoring me via
https://www.patreon.com/join/dleidert
Attachment:
signature.asc
Description: This is a digitally signed message part