[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Author tests and IPC::System::Simple



On Wed, 17 Dec 2008 19:44:50 +1100, Paul Fenwick wrote:

> I've applied a patch to IPC::System::Simple which *should* detect the $? bug
> in Perl 5.10 and use a work-around where needed[1].  Unfortunately, I don't
> have a Linux machine with 5.10 handy for me to test it on.
> If it's convenient[2], is there any chance you can test my dev version at:

Sure, no problem.
 
>   git clone git://github.com/pfenwick/ipc-system-simple.git
[..]
> 	perl Makefile.PL
> 	TEST_AUTHOR=1 make test
> or your preferred way of testing Perl modules.

$ TEST_AUTHOR=1 prove --blib --verbose t/08_core.t 
t/08_core....1..3
ok 1 - use IPC::System::Simple;
ok 2 # skip setrlimit failed
ok 3 # skip setrlimit failed
ok
        2/3 skipped: various reasons
All tests successful, 2 subtests skipped.
Files=1, Tests=3,  1 wallclock secs ( 0.09 cusr +  0.01 csys =  0.10 CPU)

Hm, that's weird. Let's try another machine:

$ TEST_AUTHOR=1 prove --blib --verbose t/08_core.t
t/08_core....1..3
ok 1 - use IPC::System::Simple;
ok 2 - Signal caught,   $? = 6
ok 3 - Coredump caught, $? = 6
ok
All tests successful.
Files=1, Tests=3,  1 wallclock secs ( 0.27 cusr +  0.02 csys =  0.29 CPU)

Looks better :)

That was on Debian unstable with Perl 5.10.0.

~~~

Debian stable, Perl 5.8.8:

$ TEST_AUTHOR=1 prove --blib --verbose t/08_core.t
t/08_core....1..3
ok 1 - use IPC::System::Simple;
ok 2 - Signal caught,   $? = 134
ok 3 - Coredump caught, $? = 134
ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.07 cusr +  0.03 csys =  0.10 CPU)

> Many thanks again for all your help!

Thanks for the quick patch!

Do you plan to release a new version on CPAN in the near future?


BTW: If I'm not mistaken t/core is not removed, neither by the tests
nor by make {real,dist,}clean.

 
Cheers,
gregor 
-- 
 .''`.   Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
   `-    NP: George Harrison: Apple Scruffs

Attachment: signature.asc
Description: Digital signature


Reply to: