[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: pinot

On Sat, 23 Feb 2008 16:21:13 +0100, Michael Biebl wrote:

> Hi David,

Hi Michael,

> A few more comments:
> 1.) debian/patches/01-fix_pinot.desktop.patch
> The desktop file seems to be correctly encoded in UTF-8, so removing the
>  Encoding line seems wrong to me.
> Could you elaborate why this patch is necessary.

It's been deprecated from the freedesktop.org specification:


| The Encoding key is deprecated. It was used to specify whether keys of type
| localestring were encoded in UTF-8 or in the specified locale. Possible values
| are UTF-8 and Legacy-Mixed. See Appendix D, The Legacy-Mixed Encoding
| (Deprecated) for more details.

Also, it triggers a lintian warning if you leave it.

> 2.) Missing recommends:
> /etc/pinot/external-filters.xml seems to use a lot of external tools
> (like unzip, pdftotext, antiword, unrtf, ...).
> I'd propose to add those tools to recommends or suggests.

Added to Suggests, thanks.

> 3.) The package installs icons into /usr/share/icons/hicolor.
> I thus recommend to add dh_icons to debian/rules. Adding a dh_desktop
> call wouldn't hurt either, even if the pinot.desktop file currently
> doesn't register any mimetypes (yet).

I forgot dh_icons, and about dh_desktop I've just read somewhere (probably
here or on -devel) about "using it even if it doesn't register any MIME type".

> 4.) deskbar-applet/python integration.
> pinot installs a deskbar module.

I missed that. :(

> This module requires python-(gnome2, dbus, etc, you have to check the
> python files). These dependencies are currently missing. Maybe it would
> make sense to split out the deskbar module into a separate package, so
> the pinot package is not affected by the additional python dependencies.

Done. I've called it deskbar-plugins-pinot (as there is already a
"deskbar-plugins-strigi", for a similar project).

> You should consider using python-support or python-central to install
> (and precompile)
> /usr/lib/deskbar-applet/modules-2.20-compatible/pinot-module.py.

Done, thanks.
I've used python-support. Is there any difference between using the two
packages you mentioned? I don't know why, I've always used python-support, and
I can't find anything on the net (still googling, though).

> The directory /usr/lib/deskbar-applet/handlers/ is not used anymore by
> deskbar-applet, so installing pinot-live.py is superfluous.

I've moved it to modules-2.20-compatible/.

You can get the new package at the usual location:


Thanks for reviewing my package,

 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

Reply to: