[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: pinot

David Paleino wrote:

>> This module requires python-(gnome2, dbus, etc, you have to check the
>> python files). These dependencies are currently missing. Maybe it would
>> make sense to split out the deskbar module into a separate package, so
>> the pinot package is not affected by the additional python dependencies.
> Done. I've called it deskbar-plugins-pinot (as there is already a
> "deskbar-plugins-strigi", for a similar project).
>> You should consider using python-support or python-central to install
>> (and precompile)
>> /usr/lib/deskbar-applet/modules-2.20-compatible/pinot-module.py.
> Done, thanks.
> I've used python-support. Is there any difference between using the two

I'm not a python (packaging) expert, so I'd be happy if others will
correct me if I'm wrong, but if you use dh_pysupport (and not
dh_python), you can remove debian/pycompat. You can also remove
XS-Python-Version from debian/control [1].
Your Depends: line should have ${python:Depends} and ${misc:Depends} and
as the python files are in a non standard directory (see man
dh_pysupport), you should pass the directory to dh_pysupport. You will
notice, that dh_pysupport now creates proper postinst/prerm hooks.

I have a patch attached for that.


P.S.: After this final round I think the package is ready for
sponsoring, which I'll happily do.

[1] /usr/share/doc/python-support/README.gz
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff --git a/debian/control b/debian/control
index 4556db1..0ef9b8c 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,6 @@ Standards-Version: 3.7.3
 Homepage: http://pinot.berlios.de
 Vcs-Svn: svn://svn.debian.org/svn/collab-maint/deb-maint/pinot/trunk/
 Vcs-Browser: http://svn.debian.org/wsvn/collab-maint/deb-maint/pinot/trunk/?rev=0&op=log
-XS-Python-Version: all
 Package: pinot
 Architecture: any
@@ -32,7 +31,7 @@ Description: search engine for local files based on Xapian
 Package: deskbar-plugins-pinot
 Architecture: all
-Depends: deskbar-applet (>= 2.20), pinot, python-gnome2, python-gobject, 
+Depends: ${python:Depends}, ${misc:Depends}, deskbar-applet (>= 2.20), pinot, python-gnome2, python-gobject, 
 Description: deskbar plugin to search files with pinot
  Pinot provides a D-Bus service that crawls, indexes your documents and
diff --git a/debian/pycompat b/debian/pycompat
deleted file mode 100644
index 0cfbf08..0000000
--- a/debian/pycompat
+++ /dev/null
@@ -1 +0,0 @@
diff --git a/debian/rules b/debian/rules
index e2e2a6c..3a1f8fc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -54,7 +54,7 @@ binary-arch: build install
-	dh_pysupport
+	dh_pysupport /usr/lib/deskbar-applet/modules-2.20-compatible/

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: