[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] stunnel4 (updated package, adoption, RFS repost)


On Thu, 23 Aug 2007, Kapil Hari Paranjape wrote:
> Package looks fine. I'm currently updating my local pbuilder base and
> will upload when that is done.

Unfortunately, I just realised that there are a few more changes that
I think you should make!

While looking through your debian/rules I found under the install

       cd src; $(MAKE) install prefix=$(CURDIR)/debian/stunnel4/usr
       cd doc; $(MAKE) install prefix=$(CURDIR)/debian/stunnel4/usr

       ln doc/stunnel.8 doc/stunnel4.8

       # Manpages will be installed by dh_installman
       rm -rf $(CURDIR)/debian/stunnel4/man
       rm -rf $(CURDIR)/debian/stunnel4/usr/man

       install -p -m 0644 tools/stunnel.conf-sample                    \

       # mv executables into /usr/bin, with propper names
       mv $(CURDIR)/debian/stunnel4/usr/sbin/stunnel                   \
       mv $(CURDIR)/debian/stunnel4/usr/sbin/stunnel3                  \
       rmdir $(CURDIR)/debian/stunnel4/usr/sbin/

       # Move docs into propper dir
       mv $(CURDIR)/debian/stunnel4/usr/share/doc/stunnel              \

1. I think it is better to use "$(MAKE) -C src" and "$(MAKE) -C doc"
   instead of the "cd src; $(MAKE)" and "cd doc; $(MAKE)" constructs.

2. Since you use "debhelper", I think it is better if you use debhelper's
   .install files to move/install files in the correct places (man dh_install).

Sorry for the late realisation.

Thanks and regards,


Attachment: signature.asc
Description: Digital signature

Reply to: