[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] stunnel4 (updated package, adoption, RFS repost)



Hello,

On Fri, 10 Aug 2007, Luis Rodrigo Gallardo Cruz wrote:
> I am looking for a sponsor for the new version 3:4.20-3
> of my package "stunnel4".
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/stunnel4
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/stunnel4/stunnel4_4.20-3.dsc

Looks nice.

I have some fixes/suggestions for you. Since this would be the first
package that I would sponsor, I hope we can learn from each other!

General remark:
===============
Please go through the package completely *as if* I were the person
who had done the packaging and you were the person performing the
sponsor-ship. Experience says that the time of adoption is probably
the time when the maximum effort is/can be put into cleaning up
packaging issues.

"Must" fixes:
==============
- The author of debian/StunnelConf-0.1.pl is not mentioned in the
  debian/copyright file. I have *not* checked all the files in your
  tree. Please check each file of the unpacked source and the debian/
  directory to find relevant attributions.
- Please fix the debian/copyright file. See
	http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html
  Specifically, one thing that *is* missing is the dates of the
  copyright assertion by the upstream author.
- Avoid patching tools/script.sh in your diff. Use quilt instead.
  In fact your collab-maint repository should ideally only contain
  the debian/ directory.
- linda complains about the empty directory /usr/share/lintian/overrides/
  I am not sure what you are using overrides here for.
- This changelog entry is not clearly written.
  * Use less cmd line args to debhelper commands in debian/rules.
  An alternative may be
  * Rewrite dh_* invocations in debian/rules.
  Or
  * Shorten dh_* invocations in debian/rules.

Optional fixes:
==============
- IMHO the README.Debian file needs better organisation. Perhaps
  three or four sections. One "Upgrading from stunnel to stunnel4",
  two "Sample Stunnel configurator", three "Howto create Tunnels",
  four "Howto create SSL keys for stunnel".
- debian/StunnelConf-0.1.pl could perhaps be placed in 
  /usr/share/doc/stunnel4/contrib/ as it is not a document but
  contributed code.
- The preferred debian/changelog entry format seems to be.
	New maintainer. Closes: #416955.
		rather than
	Adopt package (closes: #416955).
- I (have learnt to) prefer changelog entries that clearly indicate
  which files were changed rather than those that just describe the
  effect of the changes.

Not sure aspects:
===============
- I am not sure that the warnings in the doc/ directory are enough
  of a warning for those who have so far been using stunnel3.
  Since "stunnel" starts network tunnels through init.d or inetd
  someone could suffer quite a bit in the transition. We should
  think about this some more ...

I hope some other mentor can clarify the last issue.

Regards,

Kapil.
--

Attachment: signature.asc
Description: Digital signature


Reply to: