Re: [RFS] stunnel4 (updated package, adoption, RFS repost)
On Sat, Aug 25, 2007 at 11:11:05AM +0530, Kapil Hari Paranjape wrote:
> Hello,
>
> On Thu, 23 Aug 2007, Kapil Hari Paranjape wrote:
> > Package looks fine. I'm currently updating my local pbuilder base and
> > will upload when that is done.
>
> Unfortunately, I just realised that there are a few more changes that
> I think you should make!
>
> While looking through your debian/rules I found under the install
> rules:
>
> cd src; $(MAKE) install prefix=$(CURDIR)/debian/stunnel4/usr
> cd doc; $(MAKE) install prefix=$(CURDIR)/debian/stunnel4/usr
> 1. I think it is better to use "$(MAKE) -C src" and "$(MAKE) -C doc"
> instead of the "cd src; $(MAKE)" and "cd doc; $(MAKE)" constructs.
Agreed, but only because you use cd ; make instead of cd && make.
Justin
Reply to:
- References:
- Re: (retired) [RFS] stunnel
- From: Luis Rodrigo Gallardo Cruz <rodrigo@nul-unu.com>
- [RFS] stunnel4 (updated package, adoption, RFS repost)
- From: Luis Rodrigo Gallardo Cruz <rodrigo@nul-unu.com>
- Re: [RFS] stunnel4 (updated package, adoption, RFS repost)
- From: Kapil Hari Paranjape <kapil@imsc.res.in>
- Re: [RFS] stunnel4 (updated package, adoption, RFS repost)
- From: Luis Rodrigo Gallardo Cruz <rodrigo@nul-unu.com>
- Re: [RFS] stunnel4 (updated package, adoption, RFS repost)
- From: Kapil Hari Paranjape <kapil@imsc.res.in>
- Re: [RFS] stunnel4 (updated package, adoption, RFS repost)
- From: Kapil Hari Paranjape <kapil@imsc.res.in>