[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] Packaging fis-get



On Sat, Jan 28, 2012 at 02:05:57PM -0500, Luis Ibanez wrote:
> 
> Fixing the "postinst" script was "suspiciously" easy...
> 
> (so, I'm cross checking with Bhaskar, just in case...)
> 
> 
> The script was attempting to use rmdir to delete a temporary directory,
> that happened to still contain files.  I replaced it with "rm -rf" as it
> was
> already done in line 53 of the same script.

I really felt it was that simple and so probably no challenge.
 
> The change was:
> 
> --- postinst    (revision 9484)
> +++ postinst    (working copy)
> @@ -83,7 +83,7 @@
>      echo "... automatic configuration finished"
>      echo "##############################################"
>      cd ..
> -    rmdir TMPPOSTINST
> +    rm -rf TMPPOSTINST
>      ;;

That's the typical fix if you want to delete a directory but failed.
 
> I just committed this change as well.
> 
> Now I can build the "fis-gtm-initial" package
> and install it without error messages.

Cool.  I'll try it myself.  The next thing should probably be to use
some dir in /tmp or /var/tmp as TMPPOSTINST.  As far as I remember
something in /usr/lib was used - that's just wrong (and Bashkar agreed
to this opinion in one of his first mails in this thread).

Once you get this working its time to talk to Bashkar even more
intensively how to *use* this initial package to create the real
package.  I'm afraid I can't be of much help here - except that I
will constantly check your commits and can test and watch what
you did.

Really cool that you approached until this state.  Keep on the good
work.

Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: