On 12-02-28 at 10:46am, Jonas Smedegaard wrote: > Hi Kiwamu, > > On 12-02-28 at 11:50am, Kiwamu Okabe wrote: > > I git-pushed my changes to pandoc repo on collab-maint. > > Could you check it? > > (But you may wait > > haskell-zip-archive/haskell-texmath/haskell-citeproc-hs packages, > > because new pandoc needs them.) > > Your changes look good (from a first quick glance at it). > > Seems you forgot to push the tag created when you added the new > upstream tarball. Please do "git push --tags". > > Please always check if a package you want to work on contains a > README.source. This one contains one, and one of the things is that I > request that you bump the md5sum when updating upstream source. > > Great that you improved the watchfile. Remember to mention in > changelog (at least) all user-visible changes. I find your > improvement to the watchfile relevant to mention. > > Feel free to discuss my packaging methods, or to help improve the > wording of that README.source (ideally it should be reference to a > wiki page instead, to better reuse across the many package using it). I don't know if you have a different collaboration style in the Haskell team, but I like this detail used at the Perl and Multimedial teams: Only when actually releasing should you set the actual target suite, until then set it to UNRELEASED. That is, the first line of the changelog should not contain "unstable" but "UNRELEASED" when you push changes but do not release as a package. That way it is easier to see if HEAD of a git is work-in-progress or in sync with released code. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
Attachment:
signature.asc
Description: Digital signature