Re: new file open dialog
On Thu, Jul 17, 2003 at 10:26:13AM -0400, James Morrison wrote:
> Now this is going a bit far. The aircraft sized buttons are bad since they
> add inconsistancy into the gnome environment. Try using text only buttons
> and notice how the aircraft sized buttons still have pictures. I actually
> really like gnome 2 because it is simple and looks really nice.
>
> So the reasons to remove the patch are:
> 1) Makes gtk depend on a gconf(gnome) preference
> 2) Doesn't follow gnome conventions for buttons.
>
> The problem is with libgtk2.0-0 right?
>
> Jim
No, the reason it doesn't follow GNOME conventions for buttons is
*because* it doesn't depend on any gconf stuff to find out what the
preferences in GNOME are set to. To make it do so would be hideously
wrong, and would break all manner of plain Gtk apps which don't have any
GNOME dependencies. We either accept the patch as it is (a compromise)
or we don't use it. I have a suggestion for two improvements though...
make it look for a ~/documents directory, because I already have one of
those, and don't show the shortcut buttons for directories that don't
exist. Should be trivial to do both with one or two calls to g_file_test
with G_FILE_TEST_IS_DIR.
Regards,
Rob
Reply to: