[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Need for launchpad

On Fri, Jan 13, 2006 at 12:04:46PM +0100, Thomas Hood wrote:
> I don't think that patches-submitted-to-the-BTS is a good way to
> measure how much Ubuntu is contributing to Debian.  Ubuntu's patches
> are readily available:
>     http://people.ubuntulinux.org/~scott/patches/

I looked at the patches for e2fsprogs, and I have to conclude that
unfortunately, they patches are worse than useless.  It's not clear
exactly what is being diffed against what, but if I had to guess it's
a diff of Debian stable or Debian testing versus the latest in Ubuntu
unstable --- or whatever is their development branch.  

Why do that say that?  Because the vast majority of the patch is my
own latest changes made to the Debian unstable package.  i.e., just to
show you a diff from changelog file:

diff -pruN e2fsprogs_1.38-1.1/debian/changelog e2fsprogs_1.38-2ubuntu1/debian/changelog
--- e2fsprogs_1.38-1.1/debian/changelog	2005-12-06 13:39:00.000000000 +0000
+++ e2fsprogs_1.38-2ubuntu1/debian/changelog	2005-11-09 01:11:17.000000000 +0000
@@ -1,3 +1,32 @@
+e2fsprogs (1.38-2ubuntu1) breezy; urgency=low
+  * Merge with Debian.  (Ubuntu #13757)
+  * Remove tests/f_bad_disconnected_inode/image.gz to be able to build the
+    package.  This will (hopefully) be in the next upstream version and is
+    just used for testing.
+ -- Tollef Fog Heen <tfheen@ubuntu.com>  Tue, 23 Aug 2005 10:42:10 +0200
+e2fsprogs (1.38-2) unstable; urgency=low
+  * Previous NMU acknowledged (Closes: #317862, #320389)
+  * Fix debugfs's set_inode_fields command so it doesn't silently fail
+    when setting certain inode fields.
+  * Fix e2fsck from segfaulting on disconnected inodes that contain one or
+    more extended attributes.  (Closes: #316736, #318463)
+  * Allow mke2fs and tune2fs to take fractional percentages to the -m
+    option in mke2fs and tune2fs.  (Closes: #80205)
+  * Fix a compile_et bug which miscount the number of error messages if
+    continuations are used in the .et file, and fix compatibility problems
+    with MIT Kerberos 1.4
+  * Add extra sanity checks to protect users from unusual cirucmstances
+    where /etc/mtab may not be sane, by checking to see if the device is
+    reported busy (works on Linux 2.6) kernels.  (Closes: #319002)
+  * Fix use-after-free bug in e2fsck when finishing up the use of the
+    e2fsck context structure.
+ -- Theodore Y. Ts'o <tytso@mit.edu>  Sun, 21 Aug 2005 23:35:29 -0400


And on _top_ of that, we have all sorts of gratuitous autotools

This is roughly equivalent to submitting a patch to LKML with all
sorts of gratuitous whitespace cleanups mixed in with real,
substantive changes in a garguantuan monolithic patch, _and_ including
all of the changes between 2.6.14 and 2.6.15 in the patch that you
submit expecting the kernel developers to review it.  Go ahead, try
it.  I dare you.  :-)

> If they were submitted to the BTS then that would just create more work
> for the Debian maintainer as well as for the Ubuntu maintainer, since
> the former would have to tag the report and ensure it gets closed on
> the next upload, etc.  

I would much prefer that; at worse I can always close out the BTS
entry if I disagree with the patch with a wontfix.  But at least I
would see it.

						- Ted

Reply to: