[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please review pokerth 0.6 in svn

On Mon, Dec 17, 2007 at 04:07:39PM +0100, Evgeni Golov wrote:
> On Mon, 17 Dec 2007 12:49:20 +0100 Bas Wijnen wrote:
> > > 3. ships duplicate fonts in orig.tar.gz (lintian complains)
> > 
> > Lintian has some checks on the upstream tarball, which you cannot fix
> > yourself.  The solution is simply to send a bug report upstream and wait
> > for them to fix it.  You should not override the warning; the problem
> > still exists, you just can't fix it.
> True, but:
> I'm repackaging the source tarball anyways, so I can remove the fonts
> from there too (or should I leave it as original as possible?).

No, yes, you should leave it as original as possible.  During
repackaging, you should only
- remove non-DFSG-free content
- change the compression type (from zip or tar.bz2 usually) to tar.gz
If you're not doing that, you should not repackage.  And if you are
doing that, you should do only that.

> For upstream: I think they ship these fonts, because the app is built
> on MacOSX and Windows too, and there you probably need them.

In that case I think it's a litian bug. :-)  At least it seems that
there isn't a bug in the upstream tarball, if you don't actually install
those fonts then there isn't a bug in your package either.  It also
doesn't seem like a situation which is so unusual that lintian cannot be
expected to understand it (which would be reason for an override).

> > > 4. ships an empty avatars folder (lintian complains)
> > 
> > This is something that can be used in an override.  Alternatively, you
> > can add code to postinst/prerm to create and remove the directory (don't
> > make prerm fail if the directory can't be removed), or you can make sure
> > the program can create the directory itself if it finds it missing.
> Well, I'd just remove that dir from pokerth-data.install :)

Well, that's of course part of the options without the override. ;-)
Note that you should remove the folder when the package is removed,
assuming that the program will create it by itself.


I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply to: