[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please review pokerth 0.6 in svn

On Mon, Dec 17, 2007 at 12:08:42PM +0100, Evgeni Golov wrote:
> yesterday I have uploaded pokerth 0.6 to svn. This version is not yet
> ready for uploading, but it needs only few fixes until that, so I want
> to ask you to have a look at it, and give any comments about the
> packaging (and the copyright file).

I didn't check the code, but I have some comments about what you wrote:

> 1. will FTBFS when built twice in a row (make distclean does not remove
> libs/*)

This is also an upstream bug, I suppose?  Then it's best to fix it in
their makefile(.am)s, and send the patch upstream as well.

If it's only a Debian issue, or if it's somehow hard to find out how to
fix it upstream, you can just remove the files from the clean target of
debian/rules of course.

> 3. ships duplicate fonts in orig.tar.gz (lintian complains)

Lintian has some checks on the upstream tarball, which you cannot fix
yourself.  The solution is simply to send a bug report upstream and wait
for them to fix it.  You should not override the warning; the problem
still exists, you just can't fix it.

> 4. ships an empty avatars folder (lintian complains)

This is something that can be used in an override.  Alternatively, you
can add code to postinst/prerm to create and remove the directory (don't
make prerm fail if the directory can't be removed), or you can make sure
the program can create the directory itself if it finds it missing.


I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply to: