[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for help: Secondlife viewer

On Sun, Nov 18, 2007 at 09:43:42AM +0000, Robin Cornelius wrote:
> Paul TBBle Hampson wrote:
>> On Mon, Nov 12, 2007 at 07:03:53PM +0100, Miriam Ruiz wrote:
>>> I've only had time to have a look at slviewer. It bothers me a bit that some
>>> files do not include a license, we should have to try to findo out where do
>>> they come from and under which license they can be distributed. Usually, for
>>> most of the countries, no license means no rights at all.
>> I'm pretty sure there's an upstream bug report about this too, I dunno
>> what kind of state it's in though. I haven't looked at their public
>> issue tracker for months.

> There was a massive change from to 1.18.4.X which added
> headers to all the cpp and h files . I still have not checked if they
> got all of them.

>> I haven't actually looked at Robin's packages myself, but I had kind of
>> hoped he'd* dragged that sort of stuff across from my packaging into
>> his.

> I've kept all the packaging the same I've only updated the upstream
> version and rebased the patches. Your header_audit.pl is still there.

> I have not checked through all the viewer files, but the cpp and h files
> seem ok now, i could be wrong as there are so many. Its other files that
> don't have any licence header at all.

Hmm. Which other files? I would expect files related to the build
process, but not included in the output (eg. SConstruct) either have
headers, or are covered by LICENSE-source.txt.

OK, I've finally grabbed your source packages, but I dunno if I'll have
time to look at them tonight, in order to be somewhat more helpful in
this discussion. ^_^

OK, I lied. I've had a quick look. I see that 44-pkgconfig-me-harder
was dropped, and 21_VWR_2488_Standalone_build_fixes approaches the
gstreamer issue a different way. However, the latter adds gstreamer
and openal as fixed pkgconfig packages, even though they are (or
should be...) optional.

In fact, a quick look at your OpenAL patch suggests that OpenAL
becomes mandatory, and FMOD support is removed? Unless this is
a direction upstream has indicated they intend to go, then it
would be better if OpenAL was optional (at compile time, like FMOD)
although I haven't looked at the llaudio code so I can't say if
it's actually non-trivial.

Either way, gstreamer is definately optional to the build process,
and the 21_VWR_2488_Standalone_build_fixes patch doesn't handle
that properly, nor does it avoid repeating pkgconfig's work in
the if gstreamer: section that the 44-pkgconfig-me-harder patch

(This just became a longer look... -_-)

There's no mention in the changelog, but 42 appears to have been dropped
since upstream now refers to the library as xmlrpc-epi as well. I only
noticed this while trying to work out why 40-know-your-distribution had
been dropped.

I'm pretty sure I mentioned this before (about openjpeg?) but you've got
numbering clashes in your dpatches.

Also, don't forget the Jira URL for patches pulled directly from Jira.

You've misspelled updating in debian/copyright, and fails in your 20_
dpatch name. Also, you appear to be missing the DEBFULLNAME and DEBEMAIL
environment variables.

I see they've added a $LicenseInfo:firstyear=2004&license=viewergpl$
to their internal SVN repository.

Anyway, hope that helps. ^_^ I'll look forward to having an SVN
repo, and see about getting that PowerPC box up.

Oh, and are you using dpatch-cowdancer-patch to edit the dpatches?
It actually came about because dpatch-edit-patch on the slviewer
source was painfully slow on my old laptop. ^_^

Hmm. Just occurred to me to look at the .py files, and sure enough,
indra/lib/python/indra/__init__.py has an 'internal' copyright header.

No contents though, as its mere existence is its function. Still worth
poking upstream. (I'll have a look later at adapting headeraudit.pl to
handle python files. Or possibly a new version.)

I've attached an updated headeraudit.pl to take advantage of the new
regularity in the copyright headers. It gives a clean report except
indra/win_crash_logger/resource.h, which is a generated file ala the
other resource.h in the debian/rules headeraudit rule.

It also can process the .py files. And it knows the MIT license header
LL are using for them.

Current failures (ignoring incorrect @file labels) are:
indra/lib/python/indra/__init__.py is under 'internal' license

Note that debian/copyright needs updating, now that nothing fails the
audit. (I note that the one file that failed the audit with an entirely
different license before has had the LL license prepended to the old

Oh, and add yourself to the copyright of the packaging. ^_^

Paul "TBBle" Hampson, B.Sc, LPI, MCSE
Very-later-year Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

License: http://creativecommons.org/licenses/by/2.1/au/

Attachment: headeraudit.pl
Description: Perl program

Attachment: pgpjaBpsAmt9U.pgp
Description: PGP signature

Reply to: