[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [patch 1/2] m68k: Atari EtherNAT (SMC91C111) driver (updated)

Hi Geert,

drivers/net/atari_91C111.c: In function 'smc_rcv':
drivers/net/atari_91C111.c:584: error: implicit declaration of function

Odd - that should have been added by my previous io.h patch (the one that was
too chatty in the comments, around July 20).

Ah, apparently I didn't apply the last hunk. Will fix.

(That's what happens when manually applying whitespace-challenged
patches :-)

I know - that's why I sent these one as attachments :-)

Duh - now where did that one come from? Seems someoene removed irq_flags from
the platform data struct between 2.6.26 and 2.6.28 ... I'll check the driver
changelog. Looks like I should work from a fresh tree anyway.

commit d280eadc4fba0bf99fb1c3b60e8c5e007f7da02c
Author: Eric Miao <eric.miao@marvell.com>
Date:   Fri Jun 6 17:13:02 2008 +0800

   [NET] smc91x: remove "irq_flags" from "struct smc91x_platdata"

Thanks. Seems I can just drop the irq_flags setting altogetheras well.

BTW, can you please run scripts/checkpatch.pl on your patches?

| total: 63 errors, 87 warnings, 2621 lines checked

Duh again ... half the errors were in the original smc91x.c but I'll clean up
my mess now.

Can they be merged?

Tough call - at this point, the Atari driver requires special case handling for setting up the timer interrupt (i.e., I can hardwire timer D as interrupt but I still need to program the timer for the first instance it gets used. May need to go into a separate module).

When I get the level 6 interrupt to work, it'll be so much easier to merge. I'll get to it :-)


Reply to: