Re: [patch 1/2] m68k: Atari EtherNAT (SMC91C111) driver (updated)
On Fri, 5 Sep 2008, Michael Schmitz wrote:
> > > Interrupts are still missing, the driver operates from a timer routine
> > > instead.
> >
> > Thanks, updated. But... it doesn't seem to compile?
> >
> > drivers/net/atari_91C111.c: In function 'smc_rcv':
> > drivers/net/atari_91C111.c:584: error: implicit declaration of function
> > 'readsw'
>
> Odd - that should have been added by my previous io.h patch (the one that was
> too chatty in the comments, around July 20).
Ah, apparently I didn't apply the last hunk. Will fix.
(That's what happens when manually applying whitespace-challenged
patches :-)
>
> > drivers/net/atari_91C111.c: In function 'smc_hardware_send_pkt':
> > drivers/net/atari_91C111.c:729: error: implicit declaration of function
> > 'writew_be'
>
> See patch 3 out of 2 (noticed that this morning only ...)
OK.
> > drivers/net/atari_91C111.c:729: error: implicit declaration of function
> > 'writesw'
>
> Same thing as the readsw function, was added by the July 20 patch.
>
> > drivers/net/atari_91C111.c: In function 'atari_ethernat_pdev_probe':
> > drivers/net/atari_91C111.c:2317: error: 'struct smc91x_platdata' has no
> > member named 'irq_flags'
>
> Duh - now where did that one come from? Seems someoene removed irq_flags from
> the platform data struct between 2.6.26 and 2.6.28 ... I'll check the driver
> changelog. Looks like I should work from a fresh tree anyway.
commit d280eadc4fba0bf99fb1c3b60e8c5e007f7da02c
Author: Eric Miao <eric.miao@marvell.com>
Date: Fri Jun 6 17:13:02 2008 +0800
[NET] smc91x: remove "irq_flags" from "struct smc91x_platdata"
> > BTW, can you please run scripts/checkpatch.pl on your patches?
> >
> > | total: 63 errors, 87 warnings, 2621 lines checked
>
> Duh again ... half the errors were in the original smc91x.c but I'll clean up
> my mess now.
Can they be merged?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Reply to: