Hi Yadd, On 4/13/22 12:31 AM, Eric Brown wrote:
Actually it looks like our packaging of shiny-server does work fine with node-sockjs-client 1.6.0 but there's an issue with the Debian version of node-sockjs-client. So there is no need to roll back to 1.5.2. When the upstream built dist/sockjs.js and dist/sockjs.min.js files [1] are used (e.g. copied into place), it works. The sockjs.js built in Debian is not the same as upstream. Could you or someone review to see if there is a problem with the build process in node-sockjs-client that might account for differences from upstream that break shiny-server? https://github.com/sockjs/sockjs-client/commit/dc105cd6500e99018fc1d701715bdb55812752f3
Sorry to pull you in here. Looks like I broke something with the last upload for node-sockjs-client (although I did test it a little) the minified files it ships does not look compatible. I did not use the gulpfile.js since it needed more modules, and simply converted it to a cli inst to get the bundled and minified files I do not know much about gulp, and hence could you please consider taking a look at this package, and maybe check if something is very broken with my changes? I'd really really appreciate if you could please take a look. Regards, Nilesh
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature