Re: shiny-server in debian
Hi Nilesh,
Actually it looks like our packaging of shiny-server does
work fine with node-sockjs-client 1.6.0 but there's an issue with the
Debian version of node-sockjs-client. So there is no need to roll back
to 1.5.2.
When the upstream built dist/sockjs.js and dist/sockjs.min.js files
[1] are used (e.g. copied
into place), it works. The sockjs.js built in Debian is not the same
as upstream.
Could you or someone review to see if there is a problem with the
build process in node-sockjs-client that might account for
differences from upstream that break shiny-server?
https://github.com/sockjs/sockjs-client/commit/dc105cd6500e99018fc1d701715bdb55812752f3
Many thanks,
Eric
On Thu, Apr 7, 2022 at 1:28 AM Eric Brown <eb@ericebrown.com> wrote:
>
> Hi Nilesh,
>
> Thanks and no worries. I have pushed the changes to the
> node-shiny-server repo that correspond to the fixes in my previous
> email. I am new to Debian packaging so please review when you have
> time and please let me know if I have made an error.
>
> > Yes, but usually we would expect the debian package to work OOTB. Maybe we
> > could ship it for now and file a release-critical bug to keep it
> > out of testing until rest stuff is sorted out.
>
> I agreed with this proposal. I do think it would work out of the box
> even with the current r-cran-shiny, but not all features and perhaps
> some bugs. The provided sample apps run and one of my own apps runs.
> I'm not sure what doesn't work with the current version so I agree
> with your suggestion and hopefully r-cran-shiny can get updated soon.
>
> Best,
> Eric
>
> On Wed, Apr 6, 2022 at 6:47 AM Nilesh Patra <nilesh@debian.org> wrote:
> >
> > Hello and apologies for late reply, I am really swamped with work and real life stuff
> > these days.
> >
> > On Tue, Apr 05, 2022 at 09:05:39PM -0400, Eric Brown wrote:
> > > Hi Nilesh, Andreas et al.
> > >
> > > We spoke about this in the Debian med videoconference. In summary,
> > > Nilesh noted he will likely be able to downgrade node-sockjs-client to
> > > 1.5.2. Upgrading r-cran-shiny is currently blocked by r-cran-bslib
> > > which can't be updated until a font issue is sorted.
> >
> > Thanks for your mail on debian-r@ atleast we can begin by packaging some fonts,
> > until the rest of the source-less fonts are made available somewhere.
> > Unfortunately it is panning out a lot slower than expected :(
> >
> > > I think it would still be fair to proceed with the shiny-server
> > > package because the end user can easily update shiny in R by running
> > > update.packages(), if they are not already on the latest shiny.
> >
> > Yes, but usually we would expect the debian package to work OOTB. Maybe we
> > could ship it for now and file a release-critical bug to keep it
> > out of testing until rest stuff is sorted out.
> >
> > > I have made some of the changes in my previous email to the
> > > node-shiny-server git, could I be granted access to the science team
> > > salsa, so I can push them for your review? My username is ericeb (I
> > > currently only have access to the R package team).
> >
> > I have added you to the team, feel free to push whatever changes you'd like.
> >
> > Regards,
> > Nilesh
>
>
>
> --
> Eric Brown MD MSc FRCPC
> For encryption, OpenPGP public key available on request.
--
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.
Reply to: