Hi Eric, Apologies again for the late reply, I am more or less on a VAC these days :( On 4/7/22 10:58 AM, Eric Brown wrote:
Thanks and no worries. I have pushed the changes to the node-shiny-server repo that correspond to the fixes in my previous email. I am new to Debian packaging so please review when you have time and please let me know if I have made an error.
I took a look, but I think this change is not right[1] per se but rest of your changes are good. We are not supposed to add node_modules inside packages. Rather, we need to patch the code to find sockjs-client and shiny-server-client. I tried doing so, built a deb and uploaded it to the same location[2]. Could you please test this if it works OK now? That'd be awesome. Alternatively you could try building the package too, if you want to apply more changes. [1]: https://salsa.debian.org/science-team/node-shiny-server/-/commit/78662bee7e1d8c0fec0d4350f1355685567c7335 [2]: https://people.debian.org/~nilesh/shiny-server/pool/main/n/node-shiny-server/ Regards, Nilesh
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature