Am Dienstag, den 07.04.2020, 20:17 -0700 schrieb Piper McCorkle: > On 4/7/20 5:15 AM, Daniel Leidert wrote: > > I see a few remaining issues. > > > > - d/copyright needs an update for upstream (check out the copyright > > notice in LICENSE). - I guess you should add yourself to the > > copyright for debian/* too. > > Updated > > > - debian/.gitattributes is still missing. dh-make-ruby will create > > it for you (remove the created file debian/ruby-tests.rake). > > Added > > > I'm not sure how I feel about the tests in test/. They require the > > bats package. It seems some of these tests are not useful for us > > and at least two are failing here. I'd guess that these tests could > > (or should?) be enabled in autopkgtest only (using > > debian/tests/control) and carefully checked if they are necessary. > > I'm not sure where you're going with this: those tests are in the > upstream tarball and I'm only running them in autopkgtest. My mistake. I missed that. I pushed your changes to ruby-team/ruby-build, finalized your changelog and uploaded the package. https://salsa.debian.org/ruby-team/ruby-build Well done. Regards, Daniel
Attachment:
signature.asc
Description: This is a digitally signed message part