Re: Salsa team, and updating ruby-build
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 4/7/20 5:15 AM, Daniel Leidert wrote:
| I see a few remaining issues.
|
| - d/copyright needs an update for upstream (check out the copyright
| notice in LICENSE). - I guess you should add yourself to the
| copyright for debian/* too.
Updated
| - debian/.gitattributes is still missing. dh-make-ruby will create
| it for you (remove the created file debian/ruby-tests.rake).
Added
| I'm not sure how I feel about the tests in test/. They require the
| bats package. It seems some of these tests are not useful for us
| and at least two are failing here. I'd guess that these tests could
| (or should?) be enabled in autopkgtest only (using
| debian/tests/control) and carefully checked if they are necessary.
I'm not sure where you're going with this: those tests are in the
upstream tarball and I'm only running them in autopkgtest.
| If you need assistance please don't hesitate to contact this list
| or join the #ruby-team IRC channel. ...> Keep up the good work!
Thank you for the help!
Piper McCorkle
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6NQlgACgkQ6KgvLJ+z
72vODhAAgwLTwZVnAcQ1fMz7uXS/S54SwNviP1psf+s8WIrJg9q8qmluLRMs3A0i
IPkxWNZuF09yFe5uvIFSwHTmJsD3tPSDOkPWOPWFEb1mncXZuBt5gyCEm6MRqWnK
tCkyQSQnDIqHg1coDXwMTOXNhypDhr0mHs+As36i88g1B9RIeQhiRdwzg2OeBnZv
8yeF1C7LY1qSiTC8Bzn6augBoDPzqiupd9N/Ks4wcUF1dfsp6x0CyPaHaJcybFhm
KFiijDCOFAp5PWs2hn9WV9UGn2U6W02Y8oiefi2/kzH6JqK0wQggm2RoHUoHceFa
iI29bvmZVoej7GIGmMkEXRMezwe5esOd00xIbONL/BmLSFimo85hmiGEJEysxvTU
sVSiLYbGVWbucTgzqE7bREBHhO864i2MInIC2GiwvjW6vtuotaTgVE5lPdPIU6JL
diytGvY9ZTV13hqglfo8JA0v2X3thu7UP08ob5lPPDBZ1rvc5uI8/tcT5Pc6lESR
ZAnKpOw+oa1iFt1AtxwK74qh1bYCciRNkKmt/t8AQel+oQTAHHTkyjk0aACn5Rb5
qjCfNvmJlQkhRRTHvcD1hdmZ8Fgdy/R67ZBtywjpv+ucyYK6fWQvSp7iHB/ltZFB
nYM2PbaEalcajve8brEKRd0sR9AsKwGYffsk6J8yQqN+Cc3APv8=
=oUrZ
-----END PGP SIGNATURE-----
Reply to: