[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please re-enable sbuild log filtering for archive rebuilds.

Le Sat, Jan 14, 2012 at 09:32:09PM -0500, Joseph R. Justice a écrit :
> 
> Without knowing the contents of these logs, or of what's being
> filtered from them (I have looked at the bug log mentioned earlier in
> this thread), I make the following general observations:

Hi Joseph,

Here is an extract from a build log of the samtools package:

  I: NOTICE: Log filtering will replace 'build/samtools-eg6khG/samtools-0.1.18' with '«PKGBUILDDIR»'
  I: NOTICE: Log filtering will replace 'build/samtools-eg6khG' with '«BUILDDIR»'
  I: NOTICE: Log filtering will replace 'var/lib/schroot/mount/sid-amd64-sbuild-9b3324e0-1f62-47c6-8efe-a3cd5862fbbd' with '«CHROOT»'

Unless the unfiltred build log contained «PKGBUILDDIR», «BUILDDIR», or
«CHROOT», no information is discarded.

Very importantly, there has been no complain that the filtering was causing
information loss, nore that it was making anything more difficult.  For the
moment, the concerns are that a) it is possible to do it outside of sbuild, b)
perfect filtering is impossible, c) it is felt that it is needed to explain
what PKGBUILDDIR, BUILDDIR and CHROOT mean when sending an extract of the build
logs to a third party.

With the filtering, many lines such as the following dissapear from the diffs.
For me, that is already very useful.  For the packages I maintain with Git, I
now systematically inspect the diff with the previous upload before sending an
update to our archive.  Many thanks to Roger for implementing this feature !

 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. kstring.c -o kstring.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. bam_aux.c -o bam_aux.o
@@ -257,8 +258,8 @@ gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSE
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. bam_reheader.c -o bam_reheader.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. kprobaln.c -o kprobaln.o
 ar -cru libbam.a bgzf.o kstring.o bam_aux.o bam.o bam_import.o sam.o bam_index.o bam_pileup.o bam_lpileup.o bam_md.o glf.o razf.o faidx.o knetfile.o bam_sort.o sam_header.o bam_reheader.o kprobaln.o
-make[2]: Leaving directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10'
-make[2]: Entering directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10/bcftools'
+make[2]: Leaving directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a'
+make[2]: Entering directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a/bcftools'
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I.. -I. bcf.c -o bcf.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I.. -I. vcf.c -o vcf.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I.. -I. bcfutils.c -o bcfutils.o
@@ -269,10 +270,10 @@ gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSE
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I.. -I. fet.c -o fet.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I.. -I. bcf2qcall.c -o bcf2qcall.o
 ar -cru libbcf.a bcf.o vcf.o bcfutils.o prob1.o ld.o kfunc.o index.o fet.o bcf2qcall.o
-make[2]: Leaving directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10/bcftools'
-make[2]: Entering directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10/misc'
+make[2]: Leaving directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a/bcftools'
+make[2]: Entering directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a/misc'
 make[2]: Nothing to be done for `lib'.
-make[2]: Leaving directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10/misc'
+make[2]: Leaving directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a/misc'
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. bam_tview.c -o bam_tview.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. bam_maqcns.c -o bam_maqcns.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. bam_plcmd.c -o bam_plcmd.o
@@ -289,24 +290,24 @@ gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSE
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. errmod.c -o errmod.o
 gcc -c -g -O2 -g -Wall -O2 -fPIC -D_FILE_OFFSET_BITS=64 -D_USE_KNETFILE -D_CURSES_LIB=1 -I. sample.c -o sample.o
 gcc -g -O2 -g -Wall -O2 -fPIC -o samtools bam_tview.o bam_maqcns.o bam_plcmd.o sam_view.o bam_rmdup.o bam_rmdupse.o bam_mate.o bam_stat.o bam_color.o bamtk.o kaln.o bam2bcf.o bam2bcf_indel.o errmod.o sample.o libbam.a -lm  -lcurses  -lz -Lbcftools -lbcf
-make[2]: Entering directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10'
-make[3]: Entering directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10'
+make[2]: Entering directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a'
+make[3]: Entering directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a'
 make[3]: Nothing to be done for `lib'.
-make[3]: Leaving directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10'
-make[3]: Entering directory `/build/charles-samtools_0.1.10-1-amd64-EzlFO6/samtools-0.1.10/bcftools'
+make[3]: Leaving directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a'
+make[3]: Entering directory `/build/charles-samtools_0.1.12a-1-amd64-dvGJbJ/samtools-0.1.12a/bcftools'


You can see more filtered and unfiltered logs at the following URLs, for
example.

  http://anonscm.debian.org/gitweb/?p=debian-med/samtools.git;a=history;f=amd64.log;hb=meta
  http://anonscm.debian.org/gitweb/?p=debian-med/bedtools.git;a=history;f=amd64.log;hb=meta

Cheers,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan
Reply to: