Re: Brightness control on PowerBook G4 1.33GHz, 12", GeForce FX Go5200

[Guido Guenther <agx@debian.org>]

On Fri, Oct 29, 2004 at 08:56:32PM +0200, Djoumé SALVETTI wrote:
> Le vendredi 10/29/04 Guido Guenther <agx@debian.org> a écrit :
> > The problem is fixed by this patch against 2.6.9:
> >  http://honk.physik.uni-konstanz.de/~agx/linux-ppc/kernel/rivafb-fix-mode-switch-and-nv30.diff
> > It also fixes rivafb for the newer 12" pbooks (NV30). Many thanks to
> > Wolfi and Joerg for testing!
> 
> I think the correct url is :
> 
> http://honk.physik.uni-konstanz.de/~agx/linux-ppc/kernel/rivafb-2.6.9-fix-mode-and-nv30.diff
> 
> I have patch a vanilla 2.6.9 kernel with it but then it fails compiling :
> 
> drivers/video/riva/fbdev.c:195: error:
> `PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200' undeclared here (not in a
>  function)
> 
> I supposed it's only a #define that is missing in include/linux/pci_ids.h
Oh yes missed that one since it's in a separate patch set (attached).
 -- Guido

--- linux-2.6.9.orig/include/linux/pci_ids.h	2004-10-18 23:55:36.000000000 +0200
+++ linux-2.6.9/include/linux/pci_ids.h	2004-10-24 18:00:16.149569880 +0200
@@ -1138,6 +1138,7 @@
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_900XGL	0x0258
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_750XGL	0x0259
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_700XGL	0x025B
+#define PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200	0x0329
 
 #define PCI_VENDOR_ID_IMS		0x10e0
 #define PCI_DEVICE_ID_IMS_8849		0x8849