Re: Brightness control on PowerBook G4 1.33GHz, 12", GeForce FX Go5200

[Djoumé SALVETTI <salvetti@crans.org>]

Le vendredi 10/29/04 Guido Guenther <agx@debian.org> a écrit :
> The problem is fixed by this patch against 2.6.9:
>  http://honk.physik.uni-konstanz.de/~agx/linux-ppc/kernel/rivafb-fix-mode-switch-and-nv30.diff
> It also fixes rivafb for the newer 12" pbooks (NV30). Many thanks to
> Wolfi and Joerg for testing!

I think the correct url is :

http://honk.physik.uni-konstanz.de/~agx/linux-ppc/kernel/rivafb-2.6.9-fix-mode-and-nv30.diff

I have patch a vanilla 2.6.9 kernel with it but then it fails compiling :

drivers/video/riva/fbdev.c:195: error:
`PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200' undeclared here (not in a
 function)

I supposed it's only a #define that is missing in include/linux/pci_ids.h

djoume@gotan:/usr/src/linux-2.6.9-rivafb$ lspci | grep VGA
0000:00:10.0 VGA compatible controller: nVidia Corporation NV34M
[GeForce FX Go5200] (rev a1)
djoume@gotan:/usr/src/linux-2.6.9-rivafb$ lspci -n | grep  00:10.0
0000:00:10.0 0300: 10de:0329 (rev a1)

Can I safely add :

#define PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200   0x0329

to pci_ids.h and try recompiling?

Or did I miss something?

Regards.
-- 
Djoumé SALVETTI