Re: Packages default config

Hi,

Well, If I exec simple script to *only* core services I can't see *real functional* problem.

On other side I *AGREE* that we have unnecessary patches/lines in debian packaging only because we are changing

default RegionOne to regionOne in packaging historically.

Thomas ,

in order to clean up the code and remove unnecessary patches/lines in debian packaging we should consider change default value of regionOne to RegionOne

as it is also in upstream code .

Simple check :)

root@debian-sid-builder:/build# for i in $(echo "keystone glance nova neutron cinder");do cd "/build/${i}" ;echo "Checkouting $i"; git checkout debian/victoria >/dev/null 2>&1 ; grep -R regionOne debian/ --color;done
Checkouting keystone
debian/keystone.templates:Default: regionOne
debian/changelog: to use regionOne and not RegionOne by default.
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.identity.publicURL = http://localhost:$(public_port)s/v2.0
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.identity.adminURL = http://localhost:$(admin_port)s/v2.0
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.identity.internalURL = http://localhost:$(public_port)s/v2.0
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.identity.name = Identity Service
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.computev21.publicURL = http://localhost:8774/v2.1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.computev21.adminURL = http://localhost:8774/v2.1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.computev21.internalURL = http://localhost:8774/v2.1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.computev21.name = Compute Service V2.1
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.volumev2.publicURL = http://localhost:8776/v2/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.volumev2.adminURL = http://localhost:8776/v2/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.volumev2.internalURL = http://localhost:8776/v2/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.volumev2.name = Volume Service V2
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.ec2.publicURL = http://localhost:8773/services/Cloud
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.ec2.adminURL = http://localhost:8773/services/Admin
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.ec2.internalURL = http://localhost:8773/services/Cloud
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.ec2.name = EC2 Service
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.image.publicURL = http://localhost:9292
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.image.adminURL = http://localhost:9292
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.image.internalURL = http://localhost:9292
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.image.name = Image Service
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.network.publicURL = http://localhost:9696
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.network.adminURL = http://localhost:9696
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.network.internalURL = http://localhost:9696
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.network.name = Network Service
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.orchestration.publicURL = http://localhost:8004/v1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.orchestration.adminURL = http://localhost:8004/v1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.orchestration.internalURL = http://localhost:8004/v1/$(tenant_id)s
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.orchestration.name = Orchestration Service
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.metering.publicURL = http://localhost:8777
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.metering.adminURL = http://localhost:8777
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.metering.internalURL = http://localhost:8777
debian/patches/fixes-keystone-default-catalog.patch:+catalog.regionOne.metering.name = Telemetry Service
Checkouting glance
Checkouting nova
debian/rules: # Cinder os_region_name set to regionOne as default value
debian/rules: pkgos-fix-config-default $(NOVA_CONF) cinder os_region_name regionOne
debian/rules: pkgos-fix-config-default $(NOVA_CONF) placement region_name regionOne
debian/changelog: * d/rules: make regionOne default value for os_region_name
debian/nova-common.templates.in:Default: regionOne
debian/nova-common.templates.in:Default: regionOne
Checkouting neutron
debian/neutron-common.templates.in:Default: regionOne
Checkouting cinder

Thanks,

Michal Arbet ( kevko )

ne 20. 12. 2020 v 18:45 odesílatel Arnaud <arnaud.morin@gmail.com> napsal:

Hey,

Thanks for your replies.
I am not saying that debconf is overwriting what I configured with ansible.
I am just surprised that, by default, the configuration that is shipped with the Debian package (e.g. for glance) is having "regionOne" hardcoded at some places, while the default for OpenStack is "RegionOne".

Also, the doc on OpenStack side (again, for glance, see [1]) is saying that we should configure the service with RegionOne.
So, of you strictly follow the doc, you will end up with a *not* working glance API.

Also, as there are multiple places where the region_name parameter can be set (e.g. in nova, we have to set it at least in neutron and cinder sections), we cannot forget one, because some of them are set by Debian packages with regionOne, while some others are *not* and are using the default RegionOne.
The result is very confusing IMHO, and that's why I proposed to completely rename it back to RegionOne.
For people that just want to configure there OS from scratch (without puppet or ansible) they will have to "vim" over all config file to set region_name manually (debconf won't help because some of them are not managed if I am correct - that's maybe a bug).

Anyway, I managed to configure my infra, so don't worry.

Again, great work.
Thanks.

[1] https://docs.openstack.org/glance/latest/install/install-debian.html

Le 20 décembre 2020 10:57:42 GMT+01:00, Michal Arbet <michal.arbet@ultimum.io> a écrit :

Hi,

Zigo, i would like to just correct you

>>
What you are saying about the default region thing, well, the Debian
packages are setting-up a default "RegionOne", when the OpenStack
standard is more "regionOne", that's truth.
<<

Debconf default is not RegionOne but regionOne :) , not as you said above ..
But, I agree this is not big problem, because region name is configurable via debconf (didn't check ...but maybe it is needed to dpkg-reconfigure debconf and set more sensitive user input to be able set region_name in debconf questions)

Kolla (and probably other solutions using deb packages) is not using debconf, not using postinst in the way how it is implemented ..they just set DEBIAN_FRONTEND=noninteractive and setting all configurations from ansible.

Kind regards,
Michal Arbet ( kevko )

čt 17. 12. 2020 v 11:31 odesílatel Arnaud Morin <arnaud.morin@gmail.com> napsal:
Hey team,

First, thanks for all the work you did on packaging OpenStack in debian.
This is amazing work.

I have been playing with the packages in the past few days, and saw some
eventual issues that I'd like to discuss with you.

First, I am *not* using OCI, mostly because I dont need it and I already
had some ansible playbooks to manage the configuration / installation of
openstack.

As far as I can see, the packages are setting some params in the config
files, such as region_name or service_name.

If I am correct, this is done thanks to openstack-pkg-tools during
postinstall.
The thing is, for example in glance, the region_name was set to
regionOne insead of RegionOne (which is the default name in OS code).
The result is that glance was not working correctly.

Of course I can overwrite this params through my ansible playbooks.
My question behind this is why are you setting some params from
packages?

Also, I did this patch [1], in order to set region_name correctly.
Would you mind checking if this is the right place to do it?

Thanks

[1] https://salsa.debian.org/openstack-team/debian/openstack-pkg-tools/-/merge_requests/1

--
Arnaud Morin