[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#659854: marked as done (RFS: vpnc/0.5.3r512-1 - Cisco-compatible VPN client (new upstream snapshot))

Your message dated Thu, 16 Feb 2012 23:22:57 +0100
with message-id <20120216222257.GX16335@belanna.comodo.priv.at>
and subject line Re: Bug#659854: RFS: vpnc/0.5.3r512-1 - Cisco-compatible VPN client (new upstream snapshot)
has caused the Debian Bug report #659854,
regarding RFS: vpnc/0.5.3r512-1 - Cisco-compatible VPN client (new upstream snapshot)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659854: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659854
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal


Dear mentors,

I am looking for a sponsor for my package "vpnc":

dget -x http://mentors.debian.net/debian/pool/main/v/vpnc/vpnc_0.5.3r512-1.dsc
http://mentors.debian.net/package/vpnc

Version 0.5.3r512-1 is the first new upstream version (SVN snapshot,
upstream hasn't done releases in a long time) uploaded to Debian in
almost two years. It includes mainly bugfixes, particularly for routing
issues, and I expect to be able to close a lot more bugs than those
already in the changelog after triaging with this new version:

vpnc (0.5.3r512-1) unstable; urgency=low

  * Imported new upstream SVN snapshot with support for Fritz!Box routers
    (closes: #629646), fixed MTU when no default route (closes: #525389).
  * Refreshed patches, dropped 07_bug496718.patch, 08_bug640978.patch
    (applied upstream).
  * Added missing ${perl:Depends}.
  * Updated debian/copyright to reflect recent work in SVN.
  * Updated README.Debian, clarified security warning (closes: #442629).
  * Properly remove obsolete conffile example.conf on upgrade.

 -- Florian Schlichting <fschlich@zedat.fu-berlin.de>  Mon, 09 Jan 2012 21:57:57 +0100


A previous upload of vpnc was sponsored by its former maintainer, Eric
Warmenhoven, who nevertheless indicated that he might not have the time
to do so in the future, and that I should seek additional sponsorship.
As he apparently hasn't found time to look at vpnc in over three weeks,
I'm now filing this sponsorship-request to ask for your comments and
review.

Florian

--- End Message ---
--- Begin Message --- 
On Thu, 16 Feb 2012 00:19:32 +0100, Florian Schlichting wrote:

> > - I think PREFIX is only needed for the install but not for the build
> >   target in debian/rules.
> you're right, I've removed the build target override

Great.
 
> > - uscan - debian/watch don't work. I don't know if there are releases
> >   planned but for the svn snapshots a get-orig-source target might be
> >   nice.
> I don't know of any planned releases, but I suspect the active
> contributors don't have access to the website... I've added a
> get-orig-source target.

Nice.
 
> (uscan works for me, only it says "remote site does not even have
> current version" -- I suppose that's what you meant?)

Exactly, sorry for being unclear.
 
> > - debian/copyright: mismatch between GPL-2+ and "version 1 ...
> >   GPL-1".
> uh, I wonder where I mis-copy-pasted that paragraph from... :-O

I have a hunch :)
 
> > - debhelper 9 might (or might not, I haven't checked) pass more
> >   hardening *FLAGS down to the build system?
> > - Similar: The package doesn't seem to honour DEB_BUILD_OPTIONS=noopt.
> dh 9 does in fact pass extra hardening options to gcc, and also honours
> DEB_BUILD_OPTIONS (and produces lots of ignored-return-value warnings).
> I bumped the dh compat level.

Thanks.
 
> > - "mk-version: 6: mk-version: Syntax error: "(" unexpected"
> >   looks a bit ugly (only triggered by dash, not by bash or zsh, and
> >   checkbashisms also whines), and it leads to
> >   "-DVERSION=\"\"" in the gcc calls.
> ...and an empty version string for vpnc --version. That's indeed ugly! I
> had somehow thought it would just use the latest upstream release
> version without any SVN revision, and postponed the investigation, so
> thanks for spotting this!
> I'll email upstream about the bashisms (probably easiest to just switch
> the interpreter to /bin/bash), and patched the Makefile to take the full
> upstream version string from dpkg-parsechangelog.

Looks good, thank you.
 
> > (If you have the package in git somewhere reviewing future changes
> > would be more convenient for me :))
> of course!
> https://github.com/fschlich/Debian-vpnc or rather
> git clone git://github.com/fschlich/Debian-vpnc.git vpnc

Very nice, looking at the diffs of single commits is much easier!


And uploaded.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Elmore James: The Sky Is Crying

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: