[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: open-axiom

On Mon, 29 Aug 2011 02:34:03 +0400, Игорь Пашев <pashev.igor@gmail.com> wrote:
Non-text part: multipart/alternative
> Uploaded.
> http://mentors.debian.net/package/open-axiom
> Sorry for flooding ;-)

Some of these things I should have found earlier, but I thought lintian
would keep you busy longer ;).

- The second paragraph of the long description is not helpful to the
  debian user trying to decide whether to install the package; we try
  not to waste space in the description because it is stored in many
  places (e.g. /var/lib/dpkg/available).  You are welcome to add a
  README.Debian file if you want to say more about the project.

- rather than putting TODO in debian/control, it is better have a
  seperate TODO file that will be installed by dh_installdocs

- In your debian/copyright file, you should mention the license for your
  packaging. It would be a good idea to have a seperate header line for
  license and to explicitly say by each copyright holder (NAG, Axiom
  Team) what license applies (do they all use the BSD-like mentioning
  NAG, or are there variants?).

- I'm confused why debian/open-axiom.png is listed in
  debian/source/include-binaries, but not include in the source
  package. Previous experiment?

- Don't think removing the "compiled from" lines is needed, but it is
  your call. The shebang lines I agree should go.

- at some point you should consider adding some metadata to your
  patches. I typically just use git-format-patch, but if using straight
  quilt you may want to look at http://dep.debian.net/deps/dep3/.

Anyway I have to run, Hurricane Irene is making my power flicker on and


Attachment: pgp7bWfhEikbG.pgp
Description: PGP signature

Reply to: