[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: flare



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2011-08-23 20:55, Vincent Cheng wrote:
> On Tue, Aug 23, 2011 at 11:19 AM, Jan-Hendrik (hennr) Peters
> <hennr@hennr.name> wrote:
>> But there is another lintian warning that bugs me and I could use some
>> advices with this one:
>> W: flare: executable-not-elf-or-script usr/share/games/flare/fonts/white.png
>>
>> I checked the orig.tar.gz The file is not executable at all.
>> After packaging, the file is executable, I greped for white.png in the
>> debian folder but only found a md5sum.
>> Any ideas why this file gets the x flag?
>> I can't find anything special about it:
>>
>> $ file fonts/white.png
>> fonts/white.png: PNG image data, 128 x 72, 8-bit/color RGBA, non-interlaced
> 
> I've no idea why a .png image would be made executable by debhelper,

hmm, but doing:
$ ls -l fonts/white.png
- -rwxr-x--- 1 zmoelnig iemusers 1876 18. Jul 10:49 fonts/white.png

and
$ tar tvzf ../flare_0.14.1.orig.tar.gz  | grep white
- -rwxr-xr-x henner/henner    1876 2011-07-18 10:49 ./fonts/white.png

so the original file definitely _is_ executable.

so the file became executable

> but I suppose you could change it manually yourself, e.g.:
> 
> override_dh_fixperms:
>     dh_fixperms
>     chmod -x usr/share/games/flare/fonts/white.png
> 
> (This is probably a rather ugly workaround though...)

and it makes the package FTBFS on my machine:
<snip>
make[1]: Entering directory `/tmp/deb/flare/flare-0.14.1'
dh_fixperms
chmod -x debian/flare/usr/share/games/flare/fonts/white.png
chmod: debian/flare/usr/share/games/flare/fonts/white.png: new
permissions are rw-r--r-x, not rw-r--r--
make[1]: *** [override_dh_fixperms] Error 1
</snip>

probably using "chmod a-x usr/share/games/flare/fonts/white.png" will do
a better job.

oh, and your orig.tar.gz contains a .git directory that seems to not
come from upstream at all.


fgmasdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5UvKMACgkQkX2Xpv6ydvQtRwCdGJM1u1joG07N1XZZ+BGoRpfB
wSkAnRGdriPmGQDGK9YerkZAHnHpwulF
=fMZB
-----END PGP SIGNATURE-----

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


Reply to: