[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: flare



Hi again.

On 08/23/2011 07:05 AM, Vincent Cheng wrote:

> - Please try to make your package lintian-clean before asking for a
> RFS. As you may have noticed at [1], your package has a few warnings
> that should be fixed; the first two can be fixed simply by making sure
> that no line in debian/control exceeds 80 characters (and that goes
> for all the files in debian/). Remember that you can use lintian-info
> if you are unsure of the meaning of a specific lintian tag, e.g.
> 
> $ lintian-info -t extended-description-line-too-long
> W: extended-description-line-too-long

done. that was easy :)

But there is another lintian warning that bugs me and I could use some
advices with this one:
W: flare: executable-not-elf-or-script usr/share/games/flare/fonts/white.png

I checked the orig.tar.gz The file is not executable at all.
After packaging, the file is executable, I greped for white.png in the
debian folder but only found a md5sum.
Any ideas why this file gets the x flag?
I can't find anything special about it:

$ file fonts/white.png
fonts/white.png: PNG image data, 128 x 72, 8-bit/color RGBA, non-interlaced


> - debian/control: To ease backporting efforts, change your versioned
> dependency on debhelper to >= 8 (instead of >= 8.0.0).
done.

> - debian/copyright: "Please see:
> http://creativecommons.org/licenses/by-sa/3.0/legalcode"; is not
> enough; you must include the full text of the CC-BY-SA 3.0 in
> debian/copyright.
done.

> - debian/rules: you can simply your rules file and get rid of several
> overrides with...
> 
> %:
> 	dh $@ --buildsystem cmake --builddirectory=build

Could you be a bit more specific with that one?
Simply adding the two options and uncommenting the overrides
dh_auto_configure and dh_auto_build does not work:

dh build --buildsystem cmake --builddirectory=build
   dh_testdir -O--buildsystem=cmake -O--builddirectory=build
   dh_auto_configure -O--buildsystem=cmake -O--builddirectory=build
CMake Error: The source directory
"/home/henner/flare-debian/flare-packaging" does not appear to contain
CMakeLists.txt.


Thanks for you help guys.
Henner


Reply to: