Re: RFS: cppcheck, new upstream version 1.43

[Joachim Reichel <joachim.reichel@gmx.de>]

Hi,

Reijo Tomperi wrote:
> George Danchev wrote:
>> Joachim Reichel writes:
> 
>>> I checked the package and found no problems. Can't you just remove the
>>> --enable=possibleError option from the manpage (it's not listed in
>>> the -h
>>> output)?
>>>
>>> Then I'll upload the package right away.
> 
> I removed --enable=possibleError, --all and --auto-dealloc. I missed the
> --all from the changelog, I hope that doesn't matter?

not a big deal, but

> These are in version 1.43-3, which was uploaded, but doesn't yet show on
> http://mentors.debian.net/debian/pool/main/c/cppcheck/

I still do not see -3. Are you sure your upload did not fail? If you have to
upload again: why not fixing the small mistake in the changelog? I wouldn't mind
if it was a big packages, but since it is a small package ...

> (After uploading 1.43-2 I noticed that --auto-dealloc should be removed
> also.)

BTW I think it is not necessary to increment the Debian revision for each upload
to m.d.n.

>> halfway 557045, both are low priority and I hesitate to judge they
>> worth the risk upon release [1]. OTOH, to be honest I haven't seen
>> cppcheck 1.42-1 (from unstable and testing) to choke on or to omit any
>> blatant programming error, but perhaps I was just being lucky. I don't
>> mind an upload, I'm just unsure of gain/risk ratio with 1.43.
> 
> Well I can't guarantee that the version is error free, nor can I can
> even guarantee that it is better than the previous version.
> 
> But Cppcheck has 89.7% line coverage in unit tests and the tests cover a
> lot of different situations, so the checking part itself should be quite
> stable.

Among the obvious checks (md5sum of orig.tar.gz, license) I run the unit tests
and tested it on a few of my own programs. I briefly looked at the diff, but of
course, did not check the code for possible programming errors. Since we do not
have any indication that 1.43 is worse, I think it is worth the risk. It is a
leaf package, so we could reupload 1.42 anytime before the release if necessary.

Joachim