On Sun, Dec 19, 2010 at 10:44:15AM -0500, Jean Schurger wrote:
> Hi, i've updated the packages, can you have a look ?
>
> http://mentors.debian.net/debian/pool/main/f/free42/free42_1.4.66-1.dsc
>
> Jean.
Hello,
It seems good to me. It builds in a clean chroot, and is lintian clean
upto -E. debian/rules can probably be simplified with compat level 7
(dh $@) but works as is.
Minor nitpicks :
- The quote from upstream in debian/copyright should probably be
wrapped.
- In your manpage, I don't think that you have to put that much
whitespace (see attached patch).
Cheers,
--
Etienne Millon
diff -Nru a/debian/free42bin.1 b/debian/free42bin.1 --- a/debian/free42bin.1 2010-12-15 17:14:53.000000000 +0100 +++ b/debian/free42bin.1 2010-12-20 13:03:00.000000000 +0100 @@ -6,7 +6,6 @@ .RB [ \-skin .I SKIN ] - .SH "DESCRIPTION" Free42 is a complete re-implementation of the HP-42S scientific programmable RPN calculator. @@ -17,15 +16,12 @@ or .I Realistic look for the emulator. - - .SH "DOCUMENTATION" The ultimate documentation for Free42 is the manual for the HP-42S. You can obtain this manual in PDF format by purchasing the CD or DVD set from The Museum of HP Calculators (http://hpmuseum.org/). Alternatively, there is an independently written HP-42S/Free42 manual, by Jose Lauro Strapasson, which you can download free at http://joselauro.com/42s.pdf. - .SH "EDITIONS" What's the deal with the "Decimal" and "Binary" (free42dec/free42bin)? @@ -51,16 +47,13 @@ you need full HP-42S compatibility, you should use Free42 Decimal. If you don't fully understand the above, it is best to play safe and use Free42 Decimal (free42dec). - .SH "SEE ALSO" The original documentation provided upstream, available in /usr/share/doc/free42/README.gtk.gz The keymap in /usr/share/doc/free42/keymap.txt.gz - .SH "AUTHORS/CREDITS" Free42 is (C) 2004-2010, by Thomas Okken BCD support (C) 2005-2009, by Hugh Steers / voidware - .SH "LICENSE" GPL-2
Attachment:
signature.asc
Description: Digital signature