[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: UNS: Re: RFS: lshell (3rd try)

On Tue, Jul 28, 2009 at 05:31, Maximiliano Curia<maxy@debian.org> wrote:
> Hola Ignace Mouzannar!

Hola Maximiliano!

> There a few ways to check if a group exists, calling sg group_name true is a
> creative one, I not against the solution, but using getent group
> group_name is probably a more traditional approach used in a few other
> packages, in general, it's good to accept the de facto standard.

Thank you for the tip. This has been corrected.

>> The debian/rules file has been modified to use debhelper without cdbs.
> Great, I appreciate the effort, I didn't mean "do it right away", though.

No worries, it was very useful for me to create a debian/rules file
from scratch using only debhelper.

> Extra comments:
>  - control claims Build-Dependency of debhelper >= 7, but compat says 5, one
>   or the other is wrong, please fix it.

debian/compat has been set to 7.

>  - manpage:

As the manpage is gunzip'ed in the source of lshell-0.9.4, I released
a new upstream version with a non compressed manpage including the
modifications below.
The new lshell version is 0.9.5 [1].

>   - Refers to group lshellg instead of lshell

This has been corrected.

>   - Doesn't mention the default config file (/etc/lshell.conf)

I added this to the "CONFIGURATION" section.

>   - ¿Why is there a section called TODO?

I renamed this section as "NOTES" and moved it to the end of the manpage.

>  - It would be great if you document how to use lshell inside a chroot, maybe
>   even using makejail.

I am planning to work on this in the upcoming release.

A new package has been uploaded on m.d.n [2].

Thank you again for your help.

Ignace M

[1] http://lshell.ghantoos.org/
[2] The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/l/lshell
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/l/lshell/lshell_0.9.5-1.dsc

Reply to: