[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gtklp (updated package)



Hi

Dne Thu, 11 Dec 2008 23:50:51 +0800
zakame@zakame.net (Zak B. Elep) napsal(a):

> Michael Čihař writes:
> > What is reason for changes in configure.in? I simply do no see reason
> > for removing these parts.
> 
> I removed these primarily to remove a `silent' dependency on gtk+1.2
> when rebuilding the autotools (needing gtk+1.2 macros when this package
> is primarily built against gtk+2.0).  The other options (sun forte
> support and old file dialog) are in my opinion not needed in this build
> so I removed them too, but I have no problem if these were to be put
> back.

But you don't have to regenerate autotools things on build, do you? The
package builds fine if I remove both
debian/patches/15_configure.in_update.patch and
debian/patches/20_autotools_update.patch. I just think that this change
is useless and only makes the debian diff bigger at no real advantage.

> Thanks for the question; I look forward for others :)

In debian/copyright, you miss license for include/gettext.h and whole
intl directory as well as for couple of files in m4 directory. Maybe
also authors for translations should be listed...

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: