Bas Wijnen <wijnen@debian.org> writes: > On Mon, Oct 15, 2007 at 10:20:06AM -0500, Luis Rodrigo Gallardo Cruz wrote: >> Bas Wijnen <wijnen@debian.org> writes: >> > Why do you need to #define this? >> >> Just because I dislike using magic constants. > > But looking at the rest of the code, I would just use the string literal > directly. I agree with you that a define would be nicer, but it's not > how the rest of the code is done, and NMUs should be in the style of the > original as much as possible. > > Is it ok with you if I upload it with a string literal instead of a > define? Yes, no problem. Thanks for the review.
Attachment:
pgpp0Uatr8fn6.pgp
Description: PGP signature