[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: grun -- GTK based Run dialog [delayed-7 NMU]



Hi,

On Mon, Sep 24, 2007 at 03:41:27PM -0500, Luis Rodrigo Gallardo Cruz wrote:
> I am looking for a sponsor for a 7 days delayed NMU of package "grun".

I was a bit busy, and expected someone else to look at this before me,
but appearantly that didn't happen.  It seems like a serious problem, so
I'm looking at it now.  I have just one question about this part:

@@ -40,6 +40,7 @@
 #include "grun2.xpm"
 #if defined (HAVE_GETTEXT) || defined (HAVE_CATGETS)
 #include <libintl.h>
+#define UTF8 "UTF-8"
 #else
 #include "intl/libintl.h"
 #endif
@@ -1107,6 +1108,7 @@ int PASCAL WinMain(HINSTANCE hInst, HINS
 #ifndef WIN32
        setlocale (LC_ALL, "");
        bindtextdomain (PACKAGE, LOCALEDIR);
+       bind_textdomain_codeset (PACKAGE, UTF8);
        textdomain (PACKAGE);
 #endif /* WIN32 */

Why do you need to #define this?  Does it also work when intl/libintl.h
is included?  I'd expect to just use the string literal directly, this
also seems to be how other string literals are used in the source.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature


Reply to: