Florian Ernst <florian@uni-hd.de> writes: > On Mon, Mar 08, 2004 at 03:52:08PM -0800, Brian Nelson wrote: >> * The patch that changes 0's to NULL's is pointless. In C++, NULL is >> just "#define NULL 0". > > Definitely true. I preferred QA's patch over upstream's patch since > for me 'NULL' just makes it somewhat clearer. > In technical terms they are the same, unlike in plain C, but speaking > in human terms (just mine at that time) they differ. But as I don't > want my preferences to confuse anyone I reverted this change now. I'm not trying to argue you should prefer one over the other. I just think that modifications to the upstream sources should be kept to a bare minimum. In this particular case, it obscured the point of the patch, which was to initialize report.resumeCommand to 0/NULL. > I've uploaded up-to-date content (lintian / linda clean) to > http://ernst.uni-hd.de/debian/bbppp > > Please tell me if there is anything else you want me to check / fix. Well, some of your debhelper stuff could use updating. See http://lists.debian.org/debian-devel-announce/2003/debian-devel-announce-200303/msg00002.html Also, the debian/copyright is kinda funky. This is how I'd do it:
This package was debianized by Timshel Knoll <timshel@debian.org> on
Thu, 31 Aug 2000 01:28:25 +1100.
It was downloaded from http://bbtools.windsofstorm.net/sources/
Upstream Author: John Kennis <jkennis@chello.nl>
Copyright:
Copyright (C) 1998-2000 John Kennis
Translations Copyright (C) 1999 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
On Debian GNU/Linux systems, the complete text of the GNU General
Public License can be found in `/usr/share/common-licenses/GPL'.
-- Timshel Knoll <timshel@debian.org> Mon, 18 Mar 2002 02:58:54 +1100
This package version was downloaded from http://bbtools.sourceforge.net/
On Debian systems, the complete text of the GNU General Public
License, version 2, can be found in /usr/share/common-licenses/GPL-2.
-- Florian Ernst <florian_ernst@gmx.net> Mon, 1 Mar 2004 18:13:24 +0100
> A small sidenote: as 0.2.3-4 didn't make it into Sarge yet and > possibly will be delayed because of problems in the s390 buildd (at > least that's what I guess) an upload of 0.2.4-1 should be delayed as > well... In that case, the build on the broken arch will normally be retried in a few days. Like today. ;) -- Don't worry, it's *in*-flammable.
Attachment:
pgpBSSXfYqm3d.pgp
Description: PGP signature