[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: stripclub - Online Comic Reader/Archiver

Brian Nelson wrote:

A few more minor problems:

* In interface.fl:163:

callback {system("xterm -e zless /usr/share/doc/stripclub/readme.txt.gz");}

 You can't rely on xterm being available unless you depend upon it, and
 even still, that's bad practice.  Instead, you should use

* Code like stripclub:288:

   snprintf(cmd, 1023, "rm -rf %s", GetCacheFileName("", false));

 is potentially dangerous, since what if %s is "some file /", without
 the quotes?  Yeah, from the code path, it looks like that wouldn't
 happen under normal conditions, but still I'd avoid code like that
I never really did feel comfortable about that snippet of code, it was added in as a request... I'll get rid of it for debian, and remove it from the next upstream release. People can remove the cache themselves if they really want to...

* The CFLAGS and INSTALL_PROGRAM stuff in debian/rules is unused.  You
 should pass CFLAGS to the 'make' command, and just remove the
 INSTALL_PROGRAM stuff since dh_strip does the right thing anyway.
 Bah, I hate dh_make ...


* Finally, your debian/rules lacks the "binary-indep" target, which is a
 policy violation.  Quoting section 4.8:

   Both the binary-arch and binary-indep targets must exist. If one of
   them has nothing to do (which will always be the case if the source
   generates only a single binary package, whether
   architecture-dependent or not), it must still exist and must always

 So just add it and have it do nothing.

Oops. Got too zealous cleaning. Fixed.

0.6.2-2 will be up at the same URL later tonight.

Reply to: