[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RF peer review/help/sponsoring: seqcluster



On 07.08.20 13:34, Andreas Tille wrote:
> Hi Steffen,
>
> On Thu, Aug 06, 2020 at 11:05:51PM +0200, Steffen Möller wrote:
>> Because of a dependency on non-free/vienna-rna the package is only in
>> contrib. I had to extend my cowbuilder for it to find the non-free
>> dependency.
> You mention it as "Recommends".  Would it make sense to use this package
> just with vienna-rna as "Suggests"?  In this case the package could go
> into main.

I frankly don't know enough about seqcluster, yet. Likely so.

However, we have it as a build dependency since the vienna-rna
associated workflow is tested. And a build-dep on something non-free
likely prevents a submission to main, right? On a sidenote, this
dependency on vienna-rna is also what keeps bcbio out of main, which
depends on seqcluster and vienna-rna.

>> Its documentation comes with inline images which triggers
>>
>> E: python-seqcluster source: source-is-missingdoc/post/mirqc_report.html
>> line length is 770 characters (>512)
>>
>> which I would want to override - but please kindly confirm.
> Confirmed.
>
>> This warning here, well donno, I think I want to ignore it.
>>
>> W: python3-seqcluster: no-manual-pageusr/bin/seqcluster_install
> Can be probably ignored.
>
>> No idea what this is about - I used sphinx - would also want to leave
>> that warning since the file is not part of the source tree
>>
>> python-seqcluster-doc:
>> embedded-javascript-libraryusr/share/doc/python-seqcluster-doc/html/_static/language_data.js
> I think these issues should be dealt with by dh_sphinxdoc and I
> would also ignore this for the moment.
>
> I need to admit I have not built the package myself since
> I was to lazy to add non-free to my pbuilder.

Very much understood ;) I just knew I cannot send this to you without
having run this in cowbuilder over here, so I had to go for it.

I am happy to just have vienna-rna suggested instead of recommended, so
I wait for your comment on the non-free build-dep.

Best,

Steffen





Reply to: