Hello Andreas, Thanks for the heads-up. I will use the sed alternative in the future. Inspecting the autopep8 output I do not see any red flags. Also, the autopkgtest runs successfully so that should be a more concrete basis of success. > Moreover currently I think the more valuable task is bug #905206 of > profnet. Will you be able to have a look at this (in case you are > comfortable with gdb a bit)? I will make this my next task to look at. Kind regards, Shayan Doust On 18/09/2019 19:45, Andreas Tille wrote: > Hi Shayan, > > On Wed, Sep 18, 2019 at 07:15:13PM +0100, Shayan Doust wrote: >> In the meantime while I find a solution for FAST, I believe metastudents >> patch-work is complete (autopep8 used again because upstream tabbing / >> spacing). > > Meanwhile I have meanwhile learned that autopep8 can really do dangerous > things like reordering imports: > > https://lists.debian.org/debian-python/2019/09/msg00086.html > > It really left non-functional code behind. So for me personally this > program is on a black list and I rather use > > sed -P -i 's/\t/ /g' *.py > > to fix spacing. Can you confirm that your autopep8 call just fixed > spacings and did not do anything else what might be potentially harmful? > > Moreover currently I think the more valuable task is bug #905206 of > profnet. Will you be able to have a look at this (in case you are > comfortable with gdb a bit)? > > Kind regards > > Andreas. >
Attachment:
signature.asc
Description: OpenPGP digital signature